public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kim, Heungjun <riverful.kim@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: Add support for TRATS board
Date: Thu, 05 Jan 2012 20:28:45 +0900	[thread overview]
Message-ID: <4F05896D.8000000@samsung.com> (raw)
In-Reply-To: <20120105085959.2ED318223E@gemini.denx.de>

Hi Wolfgang Denk,

Thanks for the comments.

I'm preparing the modified version as you pointed out.
But I have one curious thing among your comments.

On 2012? 01? 05? 17:59, Wolfgang Denk wrote:
> Dear "HeungJun, Kim",
>
> In message<1325751248-23125-1-git-send-email-riverful.kim@samsung.com>  you wrote:
>> This patch adds support for Samsung TRATS board
>>
>> Signed-off-by: HeungJun, Kim<riverful.kim@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ...
....
>> + */
>> +uart_asm_init:
> ...
>> +system_clock_init:
> ...
>> +system_power_init:
> ...
>
> What are the compelling reasons to write thes functionms in assembler,
> and not in C?
No. There is not specific reason. It's just to fit the convention with 
lowlevel_init.S file of any other previous boards based on Exynos4 SoC.
And it's true it's easy to check the changes between these boards. So, I 
thought there's not a big problem whether this is changed to be C or not.

I'm just curious the pros of using C rather than asm in this case.
Could you explain it?

Thank you.

Regards,
Heungjun Kim

>
> Best regards,
>
> Wolfgang Denk
>

  reply	other threads:[~2012-01-05 11:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05  8:14 [U-Boot] [PATCH] ARMV7: Add support for TRATS board HeungJun, Kim
2012-01-05  8:59 ` Wolfgang Denk
2012-01-05 11:28   ` Kim, Heungjun [this message]
2012-01-05 11:34     ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2012-01-05  4:48 HeungJun, Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F05896D.8000000@samsung.com \
    --to=riverful.kim@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox