From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kim, Heungjun Date: Thu, 05 Jan 2012 20:28:45 +0900 Subject: [U-Boot] [PATCH] ARMV7: Add support for TRATS board In-Reply-To: <20120105085959.2ED318223E@gemini.denx.de> References: <1325751248-23125-1-git-send-email-riverful.kim@samsung.com> <20120105085959.2ED318223E@gemini.denx.de> Message-ID: <4F05896D.8000000@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang Denk, Thanks for the comments. I'm preparing the modified version as you pointed out. But I have one curious thing among your comments. On 2012? 01? 05? 17:59, Wolfgang Denk wrote: > Dear "HeungJun, Kim", > > In message<1325751248-23125-1-git-send-email-riverful.kim@samsung.com> you wrote: >> This patch adds support for Samsung TRATS board >> >> Signed-off-by: HeungJun, Kim >> Signed-off-by: Kyungmin Park > ... .... >> + */ >> +uart_asm_init: > ... >> +system_clock_init: > ... >> +system_power_init: > ... > > What are the compelling reasons to write thes functionms in assembler, > and not in C? No. There is not specific reason. It's just to fit the convention with lowlevel_init.S file of any other previous boards based on Exynos4 SoC. And it's true it's easy to check the changes between these boards. So, I thought there's not a big problem whether this is changed to be C or not. I'm just curious the pros of using C rather than asm in this case. Could you explain it? Thank you. Regards, Heungjun Kim > > Best regards, > > Wolfgang Denk >