[U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

stefano babic
2011-12-13T18:48:41Z

Am 13/12/2011 19:18, schrieb Wolfgang Denk:
> Dear Tom,
>
> In message <CA+M6bX=j+=UBkZ-VGoAJgFtfap+sLp4i2JypDSjJ_z-bCbw6sQ@mail.gmail.com> you wrote:
>>
>> Which covers the omap config file changes. Assuming Wolfgang doesn't
>> see a problem with using SYS_... in defines, Scott, do you want this
>> via your tree (in /next) since it's NAND or in mine since it's TI
>> boards? Assuming you don't see any problems of course. Thanks!
>
> Indeed.
>
> Stefano, what is this SYS_NAND_* supposed to mean? Either it is a
> config option, then you should name it CONFIG_SYS_NAND_* (or
> CONFIG_NAND_), or it is something else, in which case the "SYS_" is
> difficult to swallow for me (unless you have a really good
> explanation?)

As already explained by Tom: we switch to local defines instead of
CONFIG_SYS, and we get rid of CONFIG_SYS_ in board configuration files.
Inside the single file, we have some freedom to use names, and the names
suggested by Tom tells us that they are system specific, but because the
CONFIG_SYS_ is missing, they cannot be confused with U-Boot general
configuration settings. I find the names (for me) quite self explaining,
but if there is some possibility to misunderstand their meaning we can
drop the SYS_ prefix.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================