[U-Boot] [PATCH V4] nand_spl_simple: store ecc data on the stack

Stefano Babic
2011-12-14T08:49:41Z

On 14/12/2011 09:22, Simon Schwarz wrote:
> On 12/13/2011 08:33 PM, Stefano Babic wrote:
>> Currently nand_spl_simple puts it's temp data at 0x10000 offset in SDRAM
>> which is likely to contain already loaded data.
>> The patch saves the oob data and the ecc on the stack replacing
>> the fixed address in RAM.
>>
>> Signed-off-by: Stefano Babic<sbabic@denx.de>
>> CC: Ilya Yanok<yanok@emcraft.com>
>> CC: Scott Wood<scottwood@freescale.com>
>> CC: Tom Rini<tom.rini@gmail.com>
>> CC: Simon Schwarz<simonschwarzcor@googlemail.com>
>> CC: Wolfgang Denk<wd@denx.de>
>> ---
>> V4:
>> - Drop SYS_ from local defines (Wolfgang Denk, Scott Wood)
>> - drop parenthesis around defines (Scott Wood)
>>
>> V3:
>> - use local defines for CONFIG_SYS_NAND_ECCSTEPS and
>> CONFIG_SYS_NAND_ECCTOTAL (Tom Rini)
>> - drop CONFIG_SYS_NAND_ECCSTEPS from board config files
>>
>> V2:
>> - CONFIG_SYS_NAND_ECCTOTAL can always be computed (Ilya Yanok)
>> - drop all CONFIG_SYS_NAND_ECCTOTAL in arm boards using nand_simple.c
>>
> [SNIP]
>
> Hi Stefano,
>
> on which repo is this patch based? I tried to test it on u-boot but the
> patch does not apply.

Because I thought that the patch will be merged by Tom, I rebased the
patch on u-boot-ti. This is also because there is Ilya's patch:

nand_spl_simple: add support for software ECC

that modifies the same file. The patch can be applied flawlessy on top
of u-boot-ti, I have checked now again.

For testing I have then applied your SPL Linux patches, and tried to
boot linux, as I know there is a conflict with the ECC area.

Tom, it is surely better (I forget to mention) that you merge the patch
into u-boot-ti, because you have already merged Ilya's patch.

Regards,
Stefano

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================