From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Russ Date: Sun, 08 Jan 2012 20:10:15 +1100 Subject: [U-Boot] [PATCH v2 17/17] x86: Convert board_init_f_r to a processing loop In-Reply-To: References: <1325707195-3218-1-git-send-email-graeme.russ@gmail.com> <1325707195-3218-17-git-send-email-graeme.russ@gmail.com> Message-ID: <4F095D77.9000209@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/01/12 09:21, Simon Glass wrote: > Hi Graeme, > > On Wed, Jan 4, 2012 at 11:59 AM, Graeme Russ wrote: >> Create an init function array for board_init_f_r - This finalises the >> migration to a purely array based initialisation mechanism >> >> Also tweak a few comments while we are at it so everything is 'correct' >> >> Signed-off-by: Graeme Russ > > I have been through this series again and it looks good to me. I don't > suppose an Acked-by from me is much use since you are the x86 > maintainer and I admit to no knowledge of the subject, but let me know > if so. Being a maintainer does not mean I'm infallible ;) - A formal Acked-by would be appreciated > There may be some conflict between your series and the generic board > one that I just sent out yesterday but I have not tried it. But now > that series is opt-in on a board-by-board basis, we might be ok, and > in any case x86 can just opt out until everything works. Plus this series is not RFC and pending no objections (particularly from Wolfgang) I plan to put it in x86/master 'very soon (tm)' and send a pull request. Regards, Graeme