From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v2 27/28] tegra: Mark board init files for ARMv4t
Date: Mon, 09 Jan 2012 09:46:12 -0700 [thread overview]
Message-ID: <4F0B19D4.9040807@nvidia.com> (raw)
In-Reply-To: <1325895903-7703-28-git-send-email-sjg@chromium.org>
On 01/06/2012 05:25 PM, Simon Glass wrote:
> Since Tegra executes early code on an ARMv4T (but the rest on ARMv7)
> we must mark the new board init files for compilation with ARMv4t
> architecture.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
This and patch 28 seem fine to me (but I didn't look at patches 1..26 to
see what the implications of patch 28 really is!) One question below:
> diff --git a/arch/arm/cpu/armv7/tegra2/config.mk b/arch/arm/cpu/armv7/tegra2/config.mk
...
> ifdef CONFIG_TEGRA2
> CFLAGS_arch/arm/lib/board.o += -march=armv4t
> +CFLAGS_common/board_f.o += -march=armv4t
> +CFLAGS_lib/initcall.o += -march=armv4t
> endif
A pre-existing issue, but given this is a Tegra2-specific file, how come
those CFLAG assignments are ifdef'd on CONFIG_TEGRA2?
--
nvpublic
next prev parent reply other threads:[~2012-01-09 16:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 0:24 [U-Boot] [RFC PATCH v2 0/28] Create generic board init for ARM, x86, PPC Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 01/28] arm: Change board baud_rate to ulong Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 02/28] x86: " Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 03/28] arm: Only display frame buffer info if there is LCD/video support Simon Glass
2012-01-14 9:18 ` Albert ARIBAUD
2012-02-16 5:28 ` Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 04/28] x86: Remove compiler warning in sc520_timer.c Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 05/28] x86: Remove dead code in eNET Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 06/28] x86: Add initial memory barrier macros Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 07/28] ppc: " Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 08/28] Introduce generic global_data Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 09/28] Introduce generic u-boot.h file Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 10/28] Introduce generic link symbol file Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 11/28] arm: Use sections header to obtain link symbols Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 12/28] x86: Change stub example to use asm-generic/sections.h Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 13/28] Introduce a basic initcall implementation Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 14/28] Define CONFIG_SYS_LEGACY_BOARD everywhere Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 15/28] Introduce generic pre-relocation board_f.c Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 16/28] Introduce generic post-relocation board_r.c Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 17/28] Add spl load feature Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 18/28] arm: Enable generic board support Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 19/28] Add CONFIG_SYS_SYM_OFFSETS to support offset symbols Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 20/28] x86: Use sections header to obtain link symbols Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 21/28] Add x86 fields to generic global_data Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 22/28] x86: Enable generic board support Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 23/28] Add ppc fields to generic global data Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 24/28] Adjust board_f for ppc Simon Glass
2012-01-07 0:25 ` [U-Boot] [RFC PATCH v2 25/28] Adjust board_r.c for PowerPC Simon Glass
2012-01-07 0:25 ` [U-Boot] [RFC PATCH v2 26/28] ppc: Enable generic board board Simon Glass
2012-01-07 0:25 ` [U-Boot] [RFC PATCH v2 27/28] tegra: Mark board init files for ARMv4t Simon Glass
2012-01-09 16:46 ` Stephen Warren [this message]
2012-01-14 6:42 ` Simon Glass
2012-01-07 0:25 ` [U-Boot] [RFC PATCH v2 28/28] tegra: Enable generic board for Seaboard Simon Glass
2012-01-17 6:03 ` [U-Boot] [RFC PATCH v2 0/28] Create generic board init for ARM, x86, PPC Simon Glass
2012-02-16 2:05 ` Simon Glass
2012-02-16 2:28 ` Graeme Russ
2012-02-16 5:29 ` Simon Glass
2012-02-16 16:32 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0B19D4.9040807@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox