From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 09 Jan 2012 09:46:12 -0700 Subject: [U-Boot] [RFC PATCH v2 27/28] tegra: Mark board init files for ARMv4t In-Reply-To: <1325895903-7703-28-git-send-email-sjg@chromium.org> References: <1325895903-7703-1-git-send-email-sjg@chromium.org> <1325895903-7703-28-git-send-email-sjg@chromium.org> Message-ID: <4F0B19D4.9040807@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/06/2012 05:25 PM, Simon Glass wrote: > Since Tegra executes early code on an ARMv4T (but the rest on ARMv7) > we must mark the new board init files for compilation with ARMv4t > architecture. > > Signed-off-by: Simon Glass This and patch 28 seem fine to me (but I didn't look at patches 1..26 to see what the implications of patch 28 really is!) One question below: > diff --git a/arch/arm/cpu/armv7/tegra2/config.mk b/arch/arm/cpu/armv7/tegra2/config.mk ... > ifdef CONFIG_TEGRA2 > CFLAGS_arch/arm/lib/board.o += -march=armv4t > +CFLAGS_common/board_f.o += -march=armv4t > +CFLAGS_lib/initcall.o += -march=armv4t > endif A pre-existing issue, but given this is a Tegra2-specific file, how come those CFLAG assignments are ifdef'd on CONFIG_TEGRA2? -- nvpublic