From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 9 Jan 2012 15:27:44 -0600 Subject: [U-Boot] [PATCH] NAND: Allow nand_ids and nand_bbt to be compiled in SPL In-Reply-To: <201201091621.01681.vapier@gentoo.org> References: <1323127046-20694-1-git-send-email-marek.vasut@gmail.com> <201201080456.54992.vapier@gentoo.org> <4F0B42D3.1040801@freescale.com> <201201091621.01681.vapier@gentoo.org> Message-ID: <4F0B5BD0.7080204@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/09/2012 03:21 PM, Mike Frysinger wrote: > On Monday 09 January 2012 14:41:07 Scott Wood wrote: >> Unless/until the toolchain can properly GC anonymous strings, I think >> finer-grained conditional compilation is the way to go. > > i think we should use GC when it works (we've found 1 case so far where it > doesn't), and add fine grained compilation when it doesn't (with a note with > expected working versions). Anonymous strings are hardly a rare occurance. Plus, doing it on a case by cases invites breakage from people who don't/can't test the SPLs that are affected, when they add code that moves a certain file from being not-problematic to problematic. > i think this is a bug in the linker and have been > trying to make a reduced test case that i can post to the GNU binutils peeps. If and when they fix it, and the updated toolchains are in sufficiently wide use that we can stop supporting the old ones (at least for small SPL targets), we can revisit the decision. -Scott