From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 09 Jan 2012 14:45:48 -0700 Subject: [U-Boot] [PATCH 7/7] tegra: Enable I2C on Seaboard In-Reply-To: <1324923111-340-8-git-send-email-sjg@chromium.org> References: <1324923111-340-1-git-send-email-sjg@chromium.org> <1324923111-340-8-git-send-email-sjg@chromium.org> Message-ID: <4F0B600C.50507@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/26/2011 11:11 AM, Simon Glass wrote: > This enables I2C on Seaboard. ... > diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h ... > +#define CONFIG_SYS_I2C_INIT_BOARD I don't think that option is correct for Seaboard; the description in the README indicates this causes a function named i2c_init_board() to be called from boards/xxx/board.c, which is supposed to use GPIOs to unhang the I2C bus. However, this raises a couple of issues: 1) Patch 5 in this series calls i2c_init_board() ifdef CONFIG_TEGRA2_I2C rather than depending on this CONFIG option. 2) Tegra's i2c_init_board() doesn't appear to be anything to do with bus unhanging, but is instead regular I2C initialization. Perhaps the function should be renamed? -- nvpublic