From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] Changes to move hawkboard to the new infrastructure.
Date: Mon, 9 Jan 2012 16:30:56 -0700 [thread overview]
Message-ID: <4F0B78B0.6070504@ti.com> (raw)
In-Reply-To: <1326133729-6760-1-git-send-email-urwithsughosh@gmail.com>
On 01/09/2012 11:28 AM, Sughosh Ganu wrote:
> This patch moves hawkboard to the new spl infrastructure from the
> older nand_spl one. Making this change required some code refactoring
> with a couple of davinci based platforms which use spl.
>
> Removed the hawkboard_nand_config build option -- The spl code now
> gets compiled with hawkboard_config, after building the main u-boot
> image, using the CONFIG_SPL_TEXT_BASE. Modified the README.hawkboard
> to reflect the same.
[snip]
On the whole, I'm happy, but:
[snip]
> --- a/arch/arm/cpu/arm926ejs/davinci/Makefile
> +++ b/arch/arm/cpu/arm926ejs/davinci/Makefile
> @@ -38,8 +38,11 @@ COBJS-$(CONFIG_DRIVER_TI_EMAC) += lxt972.o dp83848.o et1011c.o ksz8873.o
>
> ifdef CONFIG_SPL_BUILD
> COBJS-y += spl.o
> -COBJS-$(CONFIG_SOC_DM365) += dm365_lowlevel.o
> -COBJS-$(CONFIG_SOC_DA8XX) += da850_lowlevel.o
> +COBJS-$(CONFIG_DM365_SPL) += dm365_lowlevel.o
> +COBJS-$(CONFIG_DM365_SPL) += dm365_spl.o
> +COBJS-$(CONFIG_DA850EVM_SPL) += da850_lowlevel.o
> +COBJS-$(CONFIG_DA850EVM_SPL) += da850_spl.o
> +COBJS-$(CONFIG_HAWKBOARD_SPL) += hawkboard_nand_spl.o
> endif
CONFIG_SPL_BUILD means we'll only do this on the SPL build, not the
normal build, and we already have symbols for the board and the SoC so
we shouldn't need any new CONFIG symbols here, I'm pretty sure.
--
Tom
next prev parent reply other threads:[~2012-01-09 23:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 18:28 [U-Boot] [PATCH 2/2] Changes to move hawkboard to the new infrastructure Sughosh Ganu
2012-01-09 23:30 ` Tom Rini [this message]
2012-01-10 6:30 ` Sughosh Ganu
2012-01-10 8:15 ` Christian Riesch
2012-01-10 8:42 ` Sughosh Ganu
2012-01-10 9:42 ` Heiko Schocher
2012-01-10 10:13 ` Sughosh Ganu
2012-01-10 18:15 ` [U-Boot] [PATCH 2/2 V2] Changes to move hawkboard to the new spl infrastructure Sughosh Ganu
2012-01-11 6:52 ` Heiko Schocher
2012-01-11 7:53 ` Sughosh Ganu
2012-01-11 8:54 ` Christian Riesch
2012-01-11 9:17 ` Christian Riesch
2012-01-11 9:40 ` Heiko Schocher
2012-01-11 14:37 ` [U-Boot] [PATCH 2/2 V3] " Sughosh Ganu
2012-01-11 16:10 ` Christian Riesch
2012-01-11 17:03 ` [U-Boot] [PATCH 2/2 V4] " Sughosh Ganu
2012-01-12 7:24 ` Heiko Schocher
2012-01-12 7:30 ` Sughosh Ganu
2012-01-12 7:32 ` Christian Riesch
2012-01-12 9:02 ` Christian Riesch
2012-01-12 9:39 ` Sughosh Ganu
2012-01-12 11:19 ` Christian Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0B78B0.6070504@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox