From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiangfu Liu Date: Tue, 10 Jan 2012 23:13:51 +0800 Subject: [U-Boot] [PATCH v2] add nand spl boot for qi_lb60 board In-Reply-To: <4F077789.8030401@freescale.com> References: <1325845021-31831-1-git-send-email-xiangfu@openmobilefree.net> <4F077789.8030401@freescale.com> Message-ID: <4F0C55AF.5040902@openmobilefree.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Scott thanks for your comments. PATCH v3 have sent out for you to review. On 01/07/2012 06:36 AM, Scott Wood wrote: > We are transitioning from nand_spl/ to spl/. Please try to work within > the new infrastructure. You may run into problems with size in spl/, > due to gc-sections not removing strings on components you don't need -- > I plan to fix those issues (for NAND), hopefully this merge window, by > requiring all files to be explicitly asked for. Feel free to fix them > first if you'd like. :-) > I'd like to move the new spl/. I have one question about the new spl/ I didn't see the new spl/ link to nand_spl/nand_boot.c. so how the new spl/ using nand_boot()? can we add a new define 'CONFIG_SPL_START_S_NAME', since qi_lb60 using start_spl.S for SPL, not start.S. I think better I make the nand_spl/ working. then move to the new spl/ :) >> +include $(TOPDIR)/config.mk >> + >> +LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds >> +LDFLAGS = -Bstatic -T $(LDSCRIPT) -Ttext $(CONFIG_NAND_SPL_TEXT_BASE) >> +AFLAGS += -DCONFIG_NAND_SPL >> +CFLAGS += -DCONFIG_NAND_SPL -O2 > > Why -O2 and not the -Os that you should already be inheriting from > config.mk? when I remove the -O2. it give me error: jz4740.c:(.text.sdram_init+0x14): undefined reference to `memcpy' so I keep the -O2 there. please anyone give me some advice on how to fix this. that will be great. thanks again xiangfu