* [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected
@ 2012-01-01 4:28 Marek Vasut
2012-01-10 11:05 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Marek Vasut @ 2012-01-01 4:28 UTC (permalink / raw)
To: u-boot
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
---
include/configs/m28evk.h | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
index 39c841f..dcea878 100644
--- a/include/configs/m28evk.h
+++ b/include/configs/m28evk.h
@@ -140,6 +140,7 @@
/*
* NAND
*/
+#define CONFIG_ENV_SIZE (16 * 1024)
#ifdef CONFIG_CMD_NAND
#define CONFIG_NAND_MXS
#define CONFIG_APBH_DMA
@@ -150,7 +151,6 @@
/* Environment is in NAND */
#define CONFIG_ENV_IS_IN_NAND
-#define CONFIG_ENV_SIZE (16 * 1024)
#define CONFIG_ENV_SIZE_REDUND CONFIG_ENV_SIZE
#define CONFIG_ENV_SECT_SIZE (128 * 1024)
#define CONFIG_ENV_RANGE (512 * 1024)
@@ -173,6 +173,8 @@
"512k(redundant-environment)," \
"4m(kernel)," \
"-(filesystem)"
+#else
+#define CONFIG_ENV_IS_NOWHERE
#endif
/*
--
1.7.7.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected
2012-01-01 4:28 [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected Marek Vasut
@ 2012-01-10 11:05 ` Marek Vasut
2012-01-10 11:08 ` Fabio Estevam
2012-01-11 8:02 ` Stefano Babic
2 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2012-01-10 11:05 UTC (permalink / raw)
To: u-boot
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> include/configs/m28evk.h | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> index 39c841f..dcea878 100644
> --- a/include/configs/m28evk.h
> +++ b/include/configs/m28evk.h
> @@ -140,6 +140,7 @@
> /*
> * NAND
> */
> +#define CONFIG_ENV_SIZE (16 * 1024)
> #ifdef CONFIG_CMD_NAND
> #define CONFIG_NAND_MXS
> #define CONFIG_APBH_DMA
> @@ -150,7 +151,6 @@
>
> /* Environment is in NAND */
> #define CONFIG_ENV_IS_IN_NAND
> -#define CONFIG_ENV_SIZE (16 * 1024)
> #define CONFIG_ENV_SIZE_REDUND CONFIG_ENV_SIZE
> #define CONFIG_ENV_SECT_SIZE (128 * 1024)
> #define CONFIG_ENV_RANGE (512 * 1024)
> @@ -173,6 +173,8 @@
> "512k(redundant-environment)," \
> "4m(kernel)," \
> "-(filesystem)"
> +#else
> +#define CONFIG_ENV_IS_NOWHERE
> #endif
>
> /*
BUMP
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected
2012-01-01 4:28 [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected Marek Vasut
2012-01-10 11:05 ` Marek Vasut
@ 2012-01-10 11:08 ` Fabio Estevam
2012-01-10 11:46 ` Marek Vasut
2012-01-11 8:02 ` Stefano Babic
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2012-01-10 11:08 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Sun, Jan 1, 2012 at 2:28 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> ?include/configs/m28evk.h | ? ?4 +++-
> ?1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> index 39c841f..dcea878 100644
> --- a/include/configs/m28evk.h
> +++ b/include/configs/m28evk.h
> @@ -140,6 +140,7 @@
> ?/*
> ?* NAND
> ?*/
> +#define ? ? ? ?CONFIG_ENV_SIZE ? ? ? ? ? ? ? ? (16 * 1024)
> ?#ifdef CONFIG_CMD_NAND
> ?#define ? ? ? ?CONFIG_NAND_MXS
> ?#define CONFIG_APBH_DMA
> @@ -150,7 +151,6 @@
>
> ?/* Environment is in NAND */
> ?#define ? ? ? ?CONFIG_ENV_IS_IN_NAND
> -#define ? ? ? ?CONFIG_ENV_SIZE ? ? ? ? ? ? ? ? (16 * 1024)
> ?#define ? ? ? ?CONFIG_ENV_SIZE_REDUND ? ? ? ? ?CONFIG_ENV_SIZE
> ?#define ? ? ? ?CONFIG_ENV_SECT_SIZE ? ? ? ? ? ?(128 * 1024)
> ?#define ? ? ? ?CONFIG_ENV_RANGE ? ? ? ? ? ? ? ?(512 * 1024)
> @@ -173,6 +173,8 @@
> ? ? ? ? ? ? ? ?"512k(redundant-environment)," ?\
> ? ? ? ? ? ? ? ?"4m(kernel)," ? ? ? ? ? ? ? ? ? \
> ? ? ? ? ? ? ? ?"-(filesystem)"
> +#else
> +#define ? ? ? ?CONFIG_ENV_IS_NOWHERE
Couldn't you use CONFIG_ENV_IS_IN_MMC instead of CONFIG_ENV_IS_NOWHERE here?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected
2012-01-10 11:08 ` Fabio Estevam
@ 2012-01-10 11:46 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2012-01-10 11:46 UTC (permalink / raw)
To: u-boot
> Hi Marek,
>
> On Sun, Jan 1, 2012 at 2:28 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Wolfgang Denk <wd@denx.de>
> > Cc: Stefano Babic <sbabic@denx.de>
> > ---
> > include/configs/m28evk.h | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> > index 39c841f..dcea878 100644
> > --- a/include/configs/m28evk.h
> > +++ b/include/configs/m28evk.h
> > @@ -140,6 +140,7 @@
> > /*
> > * NAND
> > */
> > +#define CONFIG_ENV_SIZE (16 * 1024)
> > #ifdef CONFIG_CMD_NAND
> > #define CONFIG_NAND_MXS
> > #define CONFIG_APBH_DMA
> > @@ -150,7 +151,6 @@
> >
> > /* Environment is in NAND */
> > #define CONFIG_ENV_IS_IN_NAND
> > -#define CONFIG_ENV_SIZE (16 * 1024)
> > #define CONFIG_ENV_SIZE_REDUND CONFIG_ENV_SIZE
> > #define CONFIG_ENV_SECT_SIZE (128 * 1024)
> > #define CONFIG_ENV_RANGE (512 * 1024)
> > @@ -173,6 +173,8 @@
> > "512k(redundant-environment)," \
> > "4m(kernel)," \
> > "-(filesystem)"
> > +#else
> > +#define CONFIG_ENV_IS_NOWHERE
>
> Couldn't you use CONFIG_ENV_IS_IN_MMC instead of CONFIG_ENV_IS_NOWHERE
> here?
We decided to not have env elsewhere until env-in-multiple-locations patch is in
place.
M
>
> Regards,
>
> Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected
2012-01-01 4:28 [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected Marek Vasut
2012-01-10 11:05 ` Marek Vasut
2012-01-10 11:08 ` Fabio Estevam
@ 2012-01-11 8:02 ` Stefano Babic
2 siblings, 0 replies; 5+ messages in thread
From: Stefano Babic @ 2012-01-11 8:02 UTC (permalink / raw)
To: u-boot
On 01/01/2012 05:28, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> include/configs/m28evk.h | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-11 8:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-01 4:28 [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected Marek Vasut
2012-01-10 11:05 ` Marek Vasut
2012-01-10 11:08 ` Fabio Estevam
2012-01-10 11:46 ` Marek Vasut
2012-01-11 8:02 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox