public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sdhc_boot: Introduce	CONFIG_FSL_FIXED_MMC_LOCATION option
Date: Wed, 11 Jan 2012 10:53:15 +0100	[thread overview]
Message-ID: <4F0D5C0B.4070703@de.bosch.com> (raw)
In-Reply-To: <CAOMZO5An=m7XD2E5Pm_m=wkFmmSvTeugZxp0=x5+X_mqWtWDyg@mail.gmail.com>

On 10.01.2012 18:28, Fabio Estevam wrote:
> Andy,
> 
> Any comment about this patch?
> 
> Without this patch we get corrupted SD cards after trying to store env
> vars on several i.MX boards.

As this seems to hurt more and more i.MX guys, could we somehow get this 
applied asap (if there are no comments any more)?

Many thanks

Dirk

> On Thu, Dec 29, 2011 at 9:54 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> Kumar/Andy,
>>
>> On Thu, Dec 29, 2011 at 7:47 AM, Stefano Babic <sbabic@denx.de> wrote:
>>> On 20/12/2011 17:33, Fabio Estevam wrote:
>>>> Since commit 97039ab98 (env_mmc: Allow board code to override the environment address)
>>>> mmc_get_env_addr is a weak-aliased function in common/env_mmc.c
>>>>
>>>> The mmc_get_env_addr implementation that exists at
>>>> board/freescale/common/sdhc_boot.c is meant to be used only for PowerPC boards,
>>>> but currently it is being used for all platforms that have CONFIG_ENV_IS_IN_MMC defined.
>>>>
>>>> Introduce CONFIG_FSL_FIXED_MMC_LOCATION so that the boards that need to use
>>>> the mmc_get_env_addr version from board/freescale/common/sdhc_boot.c could activate
>>>> this config option on their board file.
>>>>
>>>> This fixes the retrieval of CONFIG_ENV_OFFSET on non-PowerPC boards.
>>>>
>>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>> Acked-by: Stefano Babic <sbabic@denx.de>
>> Are you guys OK with this?
>>
>> Regards,
>>
>> Fabio Estevam

  reply	other threads:[~2012-01-11  9:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20 16:33 [U-Boot] [PATCH] sdhc_boot: Introduce CONFIG_FSL_FIXED_MMC_LOCATION option Fabio Estevam
2011-12-29  9:47 ` Stefano Babic
2011-12-29 11:54   ` Fabio Estevam
2012-01-10 17:28     ` Fabio Estevam
2012-01-11  9:53       ` Dirk Behme [this message]
2012-01-11 10:42         ` Stefano Babic
2011-12-29 11:57 ` Liu Hui-R64343
2011-12-29 12:38   ` Marek Vasut
2012-01-11 18:44 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0D5C0B.4070703@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox