From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Wed, 11 Jan 2012 10:53:15 +0100 Subject: [U-Boot] [PATCH] sdhc_boot: Introduce CONFIG_FSL_FIXED_MMC_LOCATION option In-Reply-To: References: <1324398781-11198-1-git-send-email-festevam@gmail.com> <4EFC3718.1030603@denx.de> Message-ID: <4F0D5C0B.4070703@de.bosch.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10.01.2012 18:28, Fabio Estevam wrote: > Andy, > > Any comment about this patch? > > Without this patch we get corrupted SD cards after trying to store env > vars on several i.MX boards. As this seems to hurt more and more i.MX guys, could we somehow get this applied asap (if there are no comments any more)? Many thanks Dirk > On Thu, Dec 29, 2011 at 9:54 AM, Fabio Estevam wrote: >> Kumar/Andy, >> >> On Thu, Dec 29, 2011 at 7:47 AM, Stefano Babic wrote: >>> On 20/12/2011 17:33, Fabio Estevam wrote: >>>> Since commit 97039ab98 (env_mmc: Allow board code to override the environment address) >>>> mmc_get_env_addr is a weak-aliased function in common/env_mmc.c >>>> >>>> The mmc_get_env_addr implementation that exists at >>>> board/freescale/common/sdhc_boot.c is meant to be used only for PowerPC boards, >>>> but currently it is being used for all platforms that have CONFIG_ENV_IS_IN_MMC defined. >>>> >>>> Introduce CONFIG_FSL_FIXED_MMC_LOCATION so that the boards that need to use >>>> the mmc_get_env_addr version from board/freescale/common/sdhc_boot.c could activate >>>> this config option on their board file. >>>> >>>> This fixes the retrieval of CONFIG_ENV_OFFSET on non-PowerPC boards. >>>> >>>> Signed-off-by: Fabio Estevam >>> Acked-by: Stefano Babic >> Are you guys OK with this? >> >> Regards, >> >> Fabio Estevam