From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Thu, 12 Jan 2012 11:53:18 +0100 Subject: [U-Boot] [PATCH v7] net: ll_temac: Add LL TEMAC driver to u-boot In-Reply-To: <20120111160704.C82141167AAC@gemini.denx.de> References: <1322771978-22008-1-git-send-email-linz@li-pro.net> <1322771978-22008-2-git-send-email-linz@li-pro.net> <20111220225629.7EF1E19E5E2D@gemini.denx.de> <4EF2F20B.6050905@monstr.eu> <20120105161026.E64FA1FD3DA@gemini.denx.de> <1325783490.7827.45.camel@keto> <20120105191953.6732DB6F26@gemini.denx.de> <1325956366.18981.47.camel@keto> <20120111160704.C82141167AAC@gemini.denx.de> Message-ID: <4F0EBB9E.2040609@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Stephan Linz, > > In message <1325956366.18981.47.camel@keto> you wrote: >> I'll provide the same way for the Xilinx LL_TEMAC driver as for the >> Xilinx AXI-EMAC driver. I prepare the microblaze-generic board code to >> support all potential Ethernet drivers but leave out the specific usage. >> You are right when you say that there is no code that refere to the new >> driver code -- there are also no configuration for this. And yes we >> adapt/change the xparameters.h out of mainline tree to enable the driver >> code -- but I think, that is not really a "out of tree port". >> >> But what would be the best implementation for unspecified targets here? > > The question is actually a very simple one here: is there any board > configuration in mainline that will actually compile and link against > this driver? If yes, then everything is fine. If not, we would not > even know if there were gross syntax errors in that code, and we would > never notce when changes to other parts break compatibility with it. > > This is why I will not add any code that is not used in mainline - > out-of-tree users don't help a bit. OK. Stephan, please send v8 with suggested changes with all patches or link to patches which are necessary to use. Please also define fake address XILINX_LLTEMAC_BASEADDR in xparameters.h to be compiled. The same we will do for axi emac driver. Stephan if you like I can add that changes to my custodian git tree and do final testing before we ask Wolfgang to merge. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian