From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] SPI: Add i.MX ECSPI driver
Date: Fri, 13 Jan 2012 08:32:25 +0100 [thread overview]
Message-ID: <4F0FDE09.2010108@de.bosch.com> (raw)
In-Reply-To: <201201121637.20848.marek.vasut@gmail.com>
On 12.01.2012 16:37, Marek Vasut wrote:
>> From: Eric Nelson <eric.nelson@boundarydevices.com>
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> CC: Jason Liu <jason.hui@linaro.org>
>> CC: Stefano Babic <sbabic@denx.de>
>> ---
...
>> + if (max_hz < imx_spi_slave->freq)
>> + imx_spi_slave->freq = max_hz ;
>
> " ;" <-- fix globally ... run tools/checkpatch.pl before submitting
First, many thanks for the review!
Just one question: Which checkpatch do you use for this?
I ran checkpatch from Linux 3.2 before submitting and got [1] (which I
think is ok). Using U-Boot's checkpatch I get [2].
Many thanks again and bet regards
Dirk
[1]
linux-2.6.git/scripts/checkpatch.pl 0001-SPI-Add-i.MX-ECSPI-driver.patch
WARNING: Use #include <linux/errno.h> instead of <asm/errno.h>
#60: FILE: drivers/spi/imx_ecspi.c:26:
+#include <asm/errno.h>
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#62: FILE: drivers/spi/imx_ecspi.c:28:
+#include <asm/io.h>
total: 0 errors, 2 warnings, 438 lines checked
0001-SPI-Add-i.MX-ECSPI-driver.patch has style problems, please review.
If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
[2]
u-boot/tools/checkpatch.pl 0001-SPI-Add-i.MX-ECSPI-driver.patch
total: 0 errors, 0 warnings, 438 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
MULTISTATEMENT_MACRO_USE_DO_WHILE
0001-SPI-Add-i.MX-ECSPI-driver.patch has no obvious style problems and
is ready for submission.
next prev parent reply other threads:[~2012-01-13 7:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 15:27 [U-Boot] [PATCH 1/2] SPI: Add i.MX ECSPI driver Dirk Behme
2012-01-12 15:27 ` [U-Boot] [PATCH 2/2] i.mx6q: SabreLite: Add SPI NOR support Dirk Behme
2012-01-12 15:32 ` Fabio Estevam
2012-01-12 15:38 ` Marek Vasut
2012-01-12 15:48 ` Fabio Estevam
2012-01-13 7:19 ` Dirk Behme
2012-01-15 1:05 ` Mike Frysinger
2012-01-15 1:04 ` Mike Frysinger
2012-01-12 15:37 ` [U-Boot] [PATCH 1/2] SPI: Add i.MX ECSPI driver Marek Vasut
2012-01-13 7:32 ` Dirk Behme [this message]
2012-01-13 12:17 ` Marek Vasut
2012-01-12 15:40 ` Fabio Estevam
2012-01-13 10:48 ` Stefano Babic
2012-01-13 11:45 ` Dirk Behme
2012-01-16 17:29 ` Eric Nelson
2012-01-16 17:38 ` Stefano Babic
2012-01-15 1:04 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0FDE09.2010108@de.bosch.com \
--to=dirk.behme@de.bosch.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox