public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v2] powerpc/85xx: move the Fman microcode from ef000000 to eff40000
Date: Fri, 13 Jan 2012 12:50:47 -0600	[thread overview]
Message-ID: <4F107D07.1080007@freescale.com> (raw)
In-Reply-To: <20120113184243.CBABC11CDEDB@gemini.denx.de>

Wolfgang Denk wrote:
> Instead  of hard-coding magic addresses which then need to be changed
> again and again, would it not make more sense to read the value from
> an environment variable so it can be easily changed without having to
> modify the source, rebuild, reinstall all the time?

(Adding Haiying)

Well, I tried that a while back and it didn't work, but I can't remember
why.  That was before I implemented a unified approach to Fman ucode
identification, so maybe it will work better now.

Part of the problem is that the meaning of the address depends on where
the ucode actually is stored -- NOR flash, NAND flash, SPI flash, etc.  I
suppose we could do something like this:

ucode_loc=nor:eff40000

And then at runtime parse the 'nor' and the 'eff40000'.  I just wish I
could remember why I rejected the env variable approach back then.

Haiying, is there ever a situation where we need to upload the QE ucode
*before* the environment variables are available?

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2012-01-13 18:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13 16:41 [U-Boot] [PATCH] [v2] powerpc/85xx: move the Fman microcode from ef000000 to eff40000 Timur Tabi
2012-01-13 18:42 ` Wolfgang Denk
2012-01-13 18:50   ` Timur Tabi [this message]
2012-01-13 20:46     ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F107D07.1080007@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox