From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v2 03/28] arm: Only display frame buffer info if there is LCD/video support
Date: Sat, 14 Jan 2012 10:18:45 +0100 [thread overview]
Message-ID: <4F114875.4080602@aribaud.net> (raw)
In-Reply-To: <1325895903-7703-4-git-send-email-sjg@chromium.org>
Hi Simon,
Le 07/01/2012 01:24, Simon Glass a ?crit :
> This value has no meaning otherwise.
>
> Signed-off-by: Simon Glass<sjg@chromium.org>
> ---
>
> common/cmd_bdinfo.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index ac8e78d..cdc595e 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -369,7 +369,9 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> print_num("reloc off", gd->reloc_off);
> print_num("irq_sp", gd->irq_sp); /* irq stack pointer */
> print_num("sp start ", gd->start_addr_sp);
> +#if defined(CONFIG_LCD) || defined(CONFIG_VIDEO)
> print_num("FB base ", gd->fb_base);
> +#endif
> return 0;
> }
>
I understand the field can have a meaningful value only for those boards
with a display, but since it apparently exists on all boards, then it
should be displayed -- or, if you feel it should not exist for boards
without displays, then you should make its existence conditional as well.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-01-14 9:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 0:24 [U-Boot] [RFC PATCH v2 0/28] Create generic board init for ARM, x86, PPC Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 01/28] arm: Change board baud_rate to ulong Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 02/28] x86: " Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 03/28] arm: Only display frame buffer info if there is LCD/video support Simon Glass
2012-01-14 9:18 ` Albert ARIBAUD [this message]
2012-02-16 5:28 ` Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 04/28] x86: Remove compiler warning in sc520_timer.c Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 05/28] x86: Remove dead code in eNET Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 06/28] x86: Add initial memory barrier macros Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 07/28] ppc: " Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 08/28] Introduce generic global_data Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 09/28] Introduce generic u-boot.h file Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 10/28] Introduce generic link symbol file Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 11/28] arm: Use sections header to obtain link symbols Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 12/28] x86: Change stub example to use asm-generic/sections.h Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 13/28] Introduce a basic initcall implementation Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 14/28] Define CONFIG_SYS_LEGACY_BOARD everywhere Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 15/28] Introduce generic pre-relocation board_f.c Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 16/28] Introduce generic post-relocation board_r.c Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 17/28] Add spl load feature Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 18/28] arm: Enable generic board support Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 19/28] Add CONFIG_SYS_SYM_OFFSETS to support offset symbols Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 20/28] x86: Use sections header to obtain link symbols Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 21/28] Add x86 fields to generic global_data Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 22/28] x86: Enable generic board support Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 23/28] Add ppc fields to generic global data Simon Glass
2012-01-07 0:24 ` [U-Boot] [RFC PATCH v2 24/28] Adjust board_f for ppc Simon Glass
2012-01-07 0:25 ` [U-Boot] [RFC PATCH v2 25/28] Adjust board_r.c for PowerPC Simon Glass
2012-01-07 0:25 ` [U-Boot] [RFC PATCH v2 26/28] ppc: Enable generic board board Simon Glass
2012-01-07 0:25 ` [U-Boot] [RFC PATCH v2 27/28] tegra: Mark board init files for ARMv4t Simon Glass
2012-01-09 16:46 ` Stephen Warren
2012-01-14 6:42 ` Simon Glass
2012-01-07 0:25 ` [U-Boot] [RFC PATCH v2 28/28] tegra: Enable generic board for Seaboard Simon Glass
2012-01-17 6:03 ` [U-Boot] [RFC PATCH v2 0/28] Create generic board init for ARM, x86, PPC Simon Glass
2012-02-16 2:05 ` Simon Glass
2012-02-16 2:28 ` Graeme Russ
2012-02-16 5:29 ` Simon Glass
2012-02-16 16:32 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F114875.4080602@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox