From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Sat, 14 Jan 2012 10:18:45 +0100
Subject: [U-Boot] [RFC PATCH v2 03/28] arm: Only display frame buffer
 info if there is LCD/video support
In-Reply-To: <1325895903-7703-4-git-send-email-sjg@chromium.org>
References: <1325895903-7703-1-git-send-email-sjg@chromium.org>
	<1325895903-7703-4-git-send-email-sjg@chromium.org>
Message-ID: <4F114875.4080602@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

Le 07/01/2012 01:24, Simon Glass a ?crit :
> This value has no meaning otherwise.
>
> Signed-off-by: Simon Glass<sjg@chromium.org>
> ---
>
>   common/cmd_bdinfo.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index ac8e78d..cdc595e 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -369,7 +369,9 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>   	print_num("reloc off", gd->reloc_off);
>   	print_num("irq_sp", gd->irq_sp);	/* irq stack pointer */
>   	print_num("sp start ", gd->start_addr_sp);
> +#if defined(CONFIG_LCD) || defined(CONFIG_VIDEO)
>   	print_num("FB base  ", gd->fb_base);
> +#endif
>   	return 0;
>   }
>

I understand the field can have a meaningful value only for those boards 
with a display, but since it apparently exists on all boards, then it 
should be displayed -- or, if you feel it should not exist for boards 
without displays, then you should make its existence conditional as well.

Amicalement,
-- 
Albert.