[U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board

[Stefano Babic <sbabic@denx.de>]

On 14/01/2012 11:06, Albert ARIBAUD wrote:

> 
> Board then compiles but with warnings for 4 declared but unused symbols.

I see also the warnings, they are related to a couple of drivers (NAND).
They need a clean-up patch to fix them.

> Considering that all it does is adding a new EHCI driver, the worst
> impact it can have is to not function properly for boards using it,
> which at the moment means omap3_beagle and tam3517; but it won't affect
> USB on existing boards.
> 
> But then I wonder why twister needs it at all, as it does not have a
> single USB config option in its header config file...

Well, that is not true...

> 
>> I can at least sent my tested-by - it was nice if you can pick it up.
> 
> *If* someone can explain to me why a patch that adds a new USB EHCI
> driver is needed by a board which does not have any "USB" in its config
> header file,

I can explain this. The twister board is based on the Technexion TAM3517
SOM. There is a common configuration files for all boards (I have also
added a second one) using this module with the TI AM3517 SOC:

	include/configs/tam3517-common.h

Because pins for USB are fixed on the SOM, the USB configuration is made
common to all boards. In tam3517-common.h you can find:

/* EHCI */
#define CONFIG_OMAP3_GPIO_5
#define CONFIG_USB_EHCI
#define CONFIG_USB_EHCI_OMAP
#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO        25
#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
#define CONFIG_USB_STORAGE


> and *unless Wolfgang says otherwise*,

..added Wolfgang in CC

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================