From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 14 Jan 2012 11:22:13 +0100 Subject: [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board In-Reply-To: <4F1155DB.4020906@denx.de> References: <1322040416-11751-2-git-send-email-sbabic@denx.de> <1322733413-13242-1-git-send-email-sbabic@denx.de> <1322733413-13242-2-git-send-email-sbabic@denx.de> <4F11410F.5000004@aribaud.net> <4F114F5C.8040906@denx.de> <4F115395.4020108@aribaud.net> <4F1155DB.4020906@denx.de> Message-ID: <4F115755.8050400@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 14/01/2012 11:15, Stefano Babic a ?crit : > On 14/01/2012 11:06, Albert ARIBAUD wrote: > >> >> Board then compiles but with warnings for 4 declared but unused symbols. > > I see also the warnings, they are related to a couple of drivers (NAND). > They need a clean-up patch to fix them. > >> Considering that all it does is adding a new EHCI driver, the worst >> impact it can have is to not function properly for boards using it, >> which at the moment means omap3_beagle and tam3517; but it won't affect >> USB on existing boards. >> >> But then I wonder why twister needs it at all, as it does not have a >> single USB config option in its header config file... > > Well, that is not true... > >> >>> I can at least sent my tested-by - it was nice if you can pick it up. >> >> *If* someone can explain to me why a patch that adds a new USB EHCI >> driver is needed by a board which does not have any "USB" in its config >> header file, > > I can explain this. The twister board is based on the Technexion TAM3517 > SOM. There is a common configuration files for all boards (I have also > added a second one) using this module with the TI AM3517 SOC: > > include/configs/tam3517-common.h > > Because pins for USB are fixed on the SOM, the USB configuration is made > common to all boards. In tam3517-common.h you can find: > > /* EHCI */ > #define CONFIG_OMAP3_GPIO_5 > #define CONFIG_USB_EHCI > #define CONFIG_USB_EHCI_OMAP > #define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 25 > #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3 > #define CONFIG_USB_STORAGE Ok, got it. I had only read the twister entry in boards.cfg and thus I thought twister was 'simple' omap3. So that leaves this: >> and *unless Wolfgang says otherwise*, > > ..added Wolfgang in CC Oops. Thanks. :) > Best regards, > Stefano Babic Amicalement, -- Albert.