From: Jens Scharsig <esw@bus-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] add new board vl_ma2sc
Date: Mon, 16 Jan 2012 09:51:08 +0100 [thread overview]
Message-ID: <4F13E4FC.3000205@bus-elektronik.de> (raw)
In-Reply-To: <4F13DE0A.6020604@denx.de>
Hello Heiko:
>
> Please check your patch with tools/checkpatch, it shows a lot
> of warnings:
>
> [hs at pollux u-boot]$ ./tools/checkpatch.pl index.html
> [...]
> total: 17 errors, 13 warnings, 1131 lines checked
>
The error based on the two code sequences
<snip>
vidinfo_t panel_info = {
vl_col: 320,
vl_row: 240,
vl_clk: 6500000,
vl_sync: ATMEL_LCDC_INVDVAL_INVERTED |
ATMEL_LCDC_INVLINE_INVERTED |
ATMEL_LCDC_INVVD_INVERTED |
ATMEL_LCDC_INVFRAME_INVERTED,
vl_bpix: (ATMEL_LCDC_PIXELSIZE_8 >> 5),
vl_tft: 1,
vl_hsync_len: 5, /* Horiz Sync Pulse Width */
vl_left_margin: 68, /* horiz back porch */
vl_right_margin: 20, /* horiz front porch */
vl_vsync_len: 2, /* vert Sync Pulse Width */
vl_upper_margin: 18, /* vert back porch */
vl_lower_margin: 4, /* vert front porch */
mmio: ATMEL_BASE_LCDC,
};
</sinp>
This block i have "stolen" from at91sam9263 board.
and
<snip>
#define CONFIG_ETHADDR 00:4D:41:02:52:43 /* MA2SC */
</sinp>
Can your teach me the right format for things like this?
Thanks
Jens Scharsig
next prev parent reply other threads:[~2012-01-16 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 7:41 [U-Boot] [PATCH] add new board vl_ma2sc Jens Scharsig
2012-01-16 8:21 ` Heiko Schocher
2012-01-16 8:51 ` Jens Scharsig [this message]
2012-01-16 9:41 ` Heiko Schocher
2012-01-16 9:57 ` Mike Frysinger
2012-01-16 10:22 ` [U-Boot] [PATCH V2] " Jens Scharsig
2012-07-07 11:06 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F13E4FC.3000205@bus-elektronik.de \
--to=esw@bus-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox