From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 16 Jan 2012 18:38:09 +0100 Subject: [U-Boot] [PATCH 1/2] SPI: Add i.MX ECSPI driver In-Reply-To: <4F145E83.1050909@boundarydevices.com> References: <1326382034-31058-1-git-send-email-dirk.behme@de.bosch.com> <4F100BFE.4060706@denx.de> <4F101958.20106@de.bosch.com> <4F145E83.1050909@boundarydevices.com> Message-ID: <4F146081.3050203@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16/01/2012 18:29, Eric Nelson wrote: >> > Good catch guys. > > The mxc_spi driver already has support for the ECSPI on i.MX6, > and just needs a small amount of glue to function. Right - and we already discussed in the past how to avoid to put specific SOC code inside the driver. In fact, the cspi_regs structure was already moved into the specific SOC header (imx-regs.h) - but the definitions of the single bits of the registers are still inside the driver, as well as the base address of the (e)cspi controllers. They should also be moved - take into acoount by implementing your changes for i.mx6. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================