From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Wed, 18 Jan 2012 07:13:19 +0100
Subject: [U-Boot] [PATCH] common, menu: do not trigger timeout again,
 if a line is read
In-Reply-To: <201201171416.33834.vapier@gentoo.org>
References: <1326788669-23493-1-git-send-email-hs@denx.de>
	<201201171416.33834.vapier@gentoo.org>
Message-ID: <4F1662FF.5000601@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Mike,

Mike Frysinger wrote:
> On Tuesday 17 January 2012 03:24:29 Heiko Schocher wrote:
>> --- a/common/menu.c
>> +++ b/common/menu.c
>>  			choice_item = menu_item_by_key(m, cbuf);
>>
>> -			if (!choice_item)
>> +			if (!choice_item) {
>>  				printf("%s not found\n", cbuf);
>> +				m->timeout = 0;
>> +			}
>>  		} else {
>>  			puts("^C\n");
>>  			return -EINTR;
> 
> the summary says "do not timeout again if a line is read", but this C code 
> seems like "do not timeout again if an item was selected but not found".  but 
> maybe i'm reading the menu code incorrectly ?

No, you are reading C code right, fix this, thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany