From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 19 Jan 2012 14:08:46 -0700 Subject: [U-Boot] [PATCH v2 4/7] tegra: Add I2C driver In-Reply-To: <1326394818-32227-5-git-send-email-sjg@chromium.org> References: <1326394818-32227-1-git-send-email-sjg@chromium.org> <1326394818-32227-5-git-send-email-sjg@chromium.org> Message-ID: <4F18865E.1070404@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/12/2012 12:00 PM, Simon Glass wrote: > From: Yen Lin > > Add basic i2c driver for Tegra2 with 8- and 16-bit address support. > The driver requires CONFIG_OF_CONTROL to obtain its configuration > from the device tree. > > (Simon Glass: sjg at chromium.org modified for upstream) > > Signed-off-by: Simon Glass Why isn't Yen's S-o-b line here, since he's listed as the patch author in git? > diff --git a/drivers/i2c/tegra2_i2c.c b/drivers/i2c/tegra2_i2c.c > +static struct i2c_bus i2c_controllers[CONFIG_SYS_MAX_I2C_BUS]; I still don't like using the wrong define here, but since I see you pushing the multi-bus stuff upstream, so I assume you'll come back and fix this when it makes a difference, so I won't object too much about this. > +void i2c_init(int speed, int slaveaddr) > +{ > + debug("i2c_init(speed=%u, slaveaddr=0x%x)\n", speed, slaveaddr); > +} What was the resolution on making this do something correct instead of ignoring the request? -- nvpublic