[U-Boot] [PATCH 2/6] mx6q: Add support for ECSPI through mxc_spi driver

Stefano Babic
2012-01-19T10:33:03Z

On 18/01/2012 21:05, Eric Nelson wrote:

>>
>> Yes, you're right - of course, I am open also to other solutions if they
>> are proofed to be better ;-).
>>
>
> I think this is about as good as things get with the current code base.
> I would argue that the driver would be better if it explicitly supported
> ECSPI and CSPI at the same time since the mx5x CPUs support it.

This means that the driver goes to support multiple interfaces at the
same time, independently if they are CSPI or ECSPI. At the moment, there
is no use case for it.

>
> Implememting that would likely require a de-structuring (removing the
> use of structs to represent the register set). IOW, a re-write.

Yes, this is also for most drivers in u-boot to support multiple
interface and not only one.

>
> That's probably not worth the effort unless someone's built hardware
> that needs it (I'm not aware of any).

Agree.

>
> On our boards that use more than one channel of SPI (for PMIC and SF),
> we're using ECSPI on both. I think the same was true on the MX51 EVK.

Yes, it is the same.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================