[U-Boot] [PATCH 2/6] mx6q: Add support for ECSPI through mxc_spi driver

Marek Vasut
2012-01-18T01:27:17Z

> On 01/17/2012 04:19 PM, Marek Vasut wrote:
> >> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
> >> ---
> >>
> >> arch/arm/include/asm/arch-mx6/imx-regs.h | 44
> >>
> >> ++++++++++++++++++++++++++++++ 1 files changed, 44 insertions(+), 0
> >> deletions(-)
> >>
> >> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
> >> b/arch/arm/include/asm/arch-mx6/imx-regs.h index 7650cb9..00040c4 100644
> >> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
> >> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
> >> @@ -190,6 +190,50 @@ struct src {
> >>
> >> u32 gpr10;
> >>
> >> };
> >>
> >> +/* ECSPI registers */
> >> +struct cspi_regs {
> >> + u32 rxdata;
> >> + u32 txdata;
> >> + u32 ctrl;
> >> + u32 cfg;
> >> + u32 intr;
> >> + u32 dma;
> >> + u32 stat;
> >> + u32 period;
> >> +};
> >
> > Sigh ... it's no fun I can have only one remark :-)
> >
> > Is this part common for all imx-es ?
>
> All i.MX6's
>
> This is a cut & paste from MX51.
>
> I was tempted to introduce an 'mxc_ecspi.h' to merge the declaration
> for i.MX5x and i.MX6 which share the ECSPI peripheral and 'mxc_cspi.h'
> for i.MX31 and i.MX35 that share the CSPI peripheral.

But you don't even need this outside of the spi driver so just put it into the
spi driver and be done with it. That'll solve your duplication issue.

M