[U-Boot] [PATCH] nand_util: correct YAFFS image write function

Kassey Lee
2012-01-20T06:17:13Z

hi, Lei, Scott:
I think this is correct,
do you have some comments ?

thanks!

BR.
Kassey

2012/1/18 Liu, Wentao <wentao.liu@intel.com>:
> In function nand_write_skip_bad(),for YAFFS filesystem part,
> write_oob() will return 0 when success, so when rval equals 0,
> it should continue to write the next page, and no break.
>
> Signed-off-by: Wentao, Liu <wentao.liu@intel.com>
>
> diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c
> index 60c778e..7ed8b18 100644
> --- a/drivers/mtd/nand/nand_util.c
> +++ b/drivers/mtd/nand/nand_util.c
> @@ -564,7 +564,7 @@ int nand_write_skip_bad(nand_info_t *nand, loff_t offset, size_t *length,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?ops.oobbuf = ops.datbuf + pagesize;
>
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?rval = nand->write_oob(nand, offset, &ops);
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if (!rval)
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if (rval != 0)
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?break;
>
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?offset += pagesize;
> --
> 1.7.4.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

--
Best regards
Kassey

Intel Mobile Communication ?Xi'an, China PRC