From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Mon, 23 Jan 2012 13:23:09 +0100 Subject: [U-Boot] [PATCH] tools/env: allow overwrite of ethaddr on default In-Reply-To: <20120105155910.8A6BBB6F26@gemini.denx.de> References: <1324580395-27004-1-git-send-email-marathon96@gmail.com> <20120105155910.8A6BBB6F26@gemini.denx.de> Message-ID: <4F1D512D.5020302@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, On 05.01.2012 16:59, Wolfgang Denk wrote: > Dear Grant Erickson, > > In message <1324580395-27004-1-git-send-email-marathon96@gmail.com> you wrote: >> This patch allows the U-Boot user space companion utility, fw_setenv, >> to overwrite the 'ethaddr' key/value pair if the current value is set >> to a per-board-configured default. >> >> This change allows 'fw_setenv' to match the behavior of 'setenv' / >> 'env set' on the U-Boot command line. >> >> Signed-off-by: Grant Erickson >> --- >> tools/env/fw_env.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) > > Applied, thanks. This patch breaks building 'env' without board configuration. This is bad cause our automatic build environment build this tool for different boards. Specific configuration is done via /etc/fw_env.config. Can't we use some build-time configuration like http://patchwork.ozlabs.org/patch/120372/ ? best regards Andreas Bie?mann