u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx28: Show CPU frequency
Date: Mon, 23 Jan 2012 17:02:25 +0100	[thread overview]
Message-ID: <4F1D8491.80603@denx.de> (raw)
In-Reply-To: <CAOMZO5CY9Xh2EqKmfWuymQ7Lp6GRcG6sxhkND8N65W9=PYYsVg@mail.gmail.com>

On 23/01/2012 16:52, Fabio Estevam wrote:
> On 1/23/12, Marek Vasut <marek.vasut@gmail.com> wrote:
> 
>> Just put it amongst the other frequencies displayed by the clock command.
> 
> What about this?
> 
> --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> @@ -170,6 +170,7 @@ int arch_cpu_init(void)
>  int print_cpuinfo(void)
>  {
>         printf("Freescale i.MX28 family\n");
> +       do_mx28_showclocks();
>         return 0;
>  }
>  #endif
> 
> It will print a lot more info though.

Well, this is the reason we have a separate function / command (clocks)
that can be called only when needed. Generally, we avoid to print too
much information if they are not required and can slow down the boot
process.

In print_cpuinfo() we output the processor type, the revision if it is
available and maybe the processor frequency - nothing more. And if we
need a complete overview of the clocks, there is the "clocks" command.

So really I prefer the patch as it is - the information printed are the
same as for other SOCs, not only i.MX.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2012-01-23 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23  2:38 [U-Boot] [PATCH] mx28: Show CPU frequency Fabio Estevam
2012-01-23  4:21 ` Marek Vasut
2012-01-23 15:52   ` Fabio Estevam
2012-01-23 16:02     ` Stefano Babic [this message]
2012-01-23 16:52       ` Marek Vasut
2012-01-24  8:36 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1D8491.80603@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).