From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/7] tegra: fdt: Add extra I2C bindings for U-Boot
Date: Mon, 23 Jan 2012 11:25:28 -0700 [thread overview]
Message-ID: <4F1DA618.9020605@nvidia.com> (raw)
In-Reply-To: <CAPnjgZ0cOquTwqg4wx3Cz1+OKXUzYoBvUi2PMA7oHN=2riOHmQ@mail.gmail.com>
On 01/22/2012 10:41 AM, Simon Glass wrote:
> Hi Stephen,
>
> On Thu, Jan 19, 2012 at 12:51 PM, Stephen Warren <swarren@nvidia.com> wrote:
>> On 01/12/2012 12:00 PM, Simon Glass wrote:
>>> Add U-Boot's peripheral clock information to the Tegra20 device tree file.
>>
>>> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
>>> index ca7b523..963cf27 100644
>>> --- a/arch/arm/dts/tegra20.dtsi
>>> +++ b/arch/arm/dts/tegra20.dtsi
>>> @@ -45,6 +45,8 @@
>>> compatible = "nvidia,tegra20-i2c";
>>> reg = <0x7000C000 0x100>;
>>> interrupts = < 70 >;
>>> + clock-frequency = <100000>;
>>
>> That's board-specific information. I'd rather not include it in the SoC
>> .dtsi file even as a default; that way, it forces people to think about
>> the correct value and put it in their board file, whereas including a
>> default means people probably won't think about it.
>
> OK I moved this into the board file - sadly this means everyone will
> need to specify it here. Or should we have a default?
I think I'd rather not have the default. That way, people need to think
about the correct value to use in their board file, rather than having
it magically work without having validated the value.
If people disagree, we'd need to update the kernel's tegra[23]0.dtsi,
since they assume ${board}.dts will set this property.
--
nvpublic
next prev parent reply other threads:[~2012-01-23 18:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 19:00 [U-Boot] [PATCH v2 0/7] tegra: Add I2C driver and associated parts Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 1/7] tegra: Rename NV_PA_PMC_BASE to TEGRA2_PMC_BASE Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 2/7] fdt: Add function to allow aliases to refer to multiple nodes Simon Glass
2012-01-19 20:49 ` Stephen Warren
2012-01-19 23:45 ` Simon Glass
2012-01-20 0:17 ` Stephen Warren
2012-01-20 0:31 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 3/7] tegra: fdt: Add extra I2C bindings for U-Boot Simon Glass
2012-01-13 6:31 ` Heiko Schocher
2012-01-13 15:02 ` Simon Glass
2012-01-19 20:51 ` Stephen Warren
2012-01-22 17:41 ` Simon Glass
2012-01-23 18:25 ` Stephen Warren [this message]
2012-02-03 23:27 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 4/7] tegra: Add I2C driver Simon Glass
2012-01-13 7:25 ` Heiko Schocher
2012-01-13 15:09 ` Simon Glass
2012-01-13 15:15 ` Heiko Schocher
2012-01-19 21:08 ` Stephen Warren
2012-02-03 23:26 ` Simon Glass
2012-02-06 21:41 ` Yen Lin
2012-02-09 17:46 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 5/7] tegra: Initialise I2C on Nvidia boards Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 6/7] tegra: Select I2C ordering for Seaboard Simon Glass
2012-01-19 20:56 ` Stephen Warren
2012-02-03 23:24 ` Simon Glass
2012-02-04 0:14 ` Stephen Warren
2012-02-04 0:19 ` Simon Glass
2012-02-04 0:25 ` Stephen Warren
2012-02-04 0:36 ` Simon Glass
2012-02-04 0:41 ` Stephen Warren
2012-02-04 0:58 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 7/7] tegra: Enable I2C on Seaboard Simon Glass
2012-01-13 6:28 ` [U-Boot] [PATCH v2 0/7] tegra: Add I2C driver and associated parts Heiko Schocher
2012-01-13 15:01 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1DA618.9020605@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox