From: "Ralf Rösch" <ralf.roesch@rw-gmbh.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC Patch] e1000: Fix PCI memory addressing and fix for receive data polling
Date: Thu, 26 Jan 2012 10:31:09 +0100 [thread overview]
Message-ID: <4F211D5D.40702@rw-gmbh.de> (raw)
Hi all,
I had some problem when using your e1000-code on a MIPS target.
Attached you will find two fixes which I would like to propose for
discussion.
- Fix 1: this has the same reason as in commit
f81ecb5d3300bf92d17302d3712f30585c182da9
- Fix 2: has to do with "C Language Operator Precedence".
I would say the expression taken by the ! operator has precedence before
the & operator.
So any bit in rd->status other than E1000_RXD_STAT_DD stops correct
detection of data reception.
(What i do not know is, if it is possible that any other bit than
E1000_RXD_STAT_DD can get active)
Please leave me in CC, because i'm not subscribed to this list.
Thanks a lot for providing u-boot.
Best regards
Ralf
--
Roesch & Walter___________________________________________
Industrie-Elektronik GmbH * Tel.: +49-7824 / 6628-0
W?rtelweg 2b/c * Fax: +49-7824 / 6628-29
D-77963 Schwanau * mailto:ralf.roesch at rw-gmbh.de
Germany * WWW: http://www.rw-gmbh.de
Amtsgericht Freiburg i.Br. HRB 391345
Gesch?ftsf?hrer: Dipl.Ing.(FH) Ralf R?sch, Dipl.Ing.(FH) Martin Walter
GnuPG key: 52ECD70F 2010-09-04 [expires: 2012-12-31]
Fingerprint: 8415 9113 5F05 D579 6685 D5AD 5CE7 5429 52EC D70F
next reply other threads:[~2012-01-26 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 9:31 Ralf Rösch [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 13:19 [U-Boot] [RFC Patch] e1000: Fix PCI memory addressing and fix for receive data polling Ralf Rösch
2012-01-26 15:52 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F211D5D.40702@rw-gmbh.de \
--to=ralf.roesch@rw-gmbh.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox