public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] TRATS: set gpio of UART correctly
Date: Thu, 26 Jan 2012 20:21:42 +0900	[thread overview]
Message-ID: <4F213746.1070906@samsung.com> (raw)

Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Signed-off-by: HeungJun, Kim <riverful.kim@samsung.com>
Cc: Chander Kashyap <chander.kashyap@linaro.org>
---
 board/samsung/trats/trats.c |   18 +++++++-----------
 1 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index f795ff0..aa4291d 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -336,21 +336,17 @@ static void board_uart_init(void)
 		(struct exynos4_gpio_part2 *)samsung_get_base_gpio_part2();
 	int i;
 
-	/* UART0-UART1 GPIOs (part1) : 0x22222222 */
-	for (i = 0; i < 7; i++) {
-		s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE);
-		s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2));
-	}
-
 	/*
-	 * UART2-UART3 GPIOs (part2) : 0x00223322
-	 * GPA1CON[3] = I2C_3_SCL (3)
+	 * UART2 GPIOs
+	 * GPA1CON[0] = UART_2_RXD(2)
+	 * GPA1CON[1] = UART_2_TXD(2)
 	 * GPA1CON[2] = I2C_3_SDA (3)
+	 * GPA1CON[3] = I2C_3_SCL (3)
 	 */
-	for (i = 0; i < 5; i++) {
+
+	for (i = 0; i < 4; i++) {
 		s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE);
-		s5p_gpio_cfg_pin(&gpio1->a1, i,
-				GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2));
+		s5p_gpio_cfg_pin(&gpio1->a1, i, GPIO_FUNC((i > 1) ? 0x3 : 0x2));
 	}
 
 	/* UART_SEL GPY4[7] (part2) at EXYNOS4 */
-- 
1.7.5.4

             reply	other threads:[~2012-01-26 11:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-26 11:21 Minkyu Kang [this message]
2012-02-06  6:06 ` [U-Boot] [PATCH] TRATS: set gpio of UART correctly Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F213746.1070906@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox