[U-Boot] [RFC Patch] e1000: Fix PCI memory addressing and fix for receive data polling

[U-Boot] [RFC Patch] e1000: Fix PCI memory addressing and fix for receive data polling

[Ralf Rösch]

Sorry, you will find now my fixes in attachment

Hi all,

I had some problem when using your e1000-code on a MIPS target.
Attached you will find two fixes which I would like to propose for
discussion.

- Fix 1: this has the same reason as in commit
f81ecb5d3300bf92d17302d3712f30585c182da9

- Fix 2: has to do with "C Language Operator Precedence".
I would say the expression taken by the ! operator has precedence before
the & operator.
So any bit in rd->status other than E1000_RXD_STAT_DD stops correct
detection of data reception.
(What i do not know is, if it is possible that any other bit than
E1000_RXD_STAT_DD can get active)

Please leave me in CC, because i'm not subscribed to this list.

Thanks a lot for providing u-boot.

Best regards
Ralf

-- 
Roesch & Walter___________________________________________
Industrie-Elektronik GmbH * Tel.: +49-7824 / 6628-0
W?rtelweg 2b/c            * Fax:  +49-7824 / 6628-29
D-77963 Schwanau          * mailto:ralf.roesch at rw-gmbh.de
Germany                   * WWW: http://www.rw-gmbh.de
Amtsgericht Freiburg i.Br. HRB 391345
Gesch?ftsf?hrer: Dipl.Ing.(FH) Ralf R?sch, Dipl.Ing.(FH) Martin Walter

GnuPG key: 52ECD70F 2010-09-04 [expires: 2012-12-31]
Fingerprint: 8415 9113 5F05 D579 6685  D5AD 5CE7 5429 52EC D70F

-------------- next part --------------
A non-text attachment was scrubbed...
Name: e1000.patch
Type: text/x-diff
Size: 828 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120126/9a43b66f/attachment.patch>

[U-Boot] [RFC Patch] e1000: Fix PCI memory addressing and fix for receive data polling

[Stefano Babic]

On 26/01/2012 14:19, Ralf R?sch wrote:
> Sorry, you will find now my fixes in attachment
> 
> Hi all,

Hi Ralf,

> 
> I had some problem when using your e1000-code on a MIPS target.
> Attached you will find two fixes which I would like to propose for
> discussion.
> 
> - Fix 1: this has the same reason as in commit
> f81ecb5d3300bf92d17302d3712f30585c182da9

Anyway, can you also describe *which* bug / behavior have you found ?

> - Fix 2: has to do with "C Language Operator Precedence".
> I would say the expression taken by the ! operator has precedence before
> the & operator.
> So any bit in rd->status other than E1000_RXD_STAT_DD stops correct
> detection of data reception.
> (What i do not know is, if it is possible that any other bit than
> E1000_RXD_STAT_DD can get active)

This seems to me a bug. However, you must send right patches for review
/ discussion. You find two issues, and you must send one patch for each
issue that will be fixed. Please have a look at:

	http://www.denx.de/wiki/U-Boot/Patches

It describes how to submit patches in the right format.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [RFC Patch] e1000: Fix PCI memory addressing and fix for receive data polling

[Ralf Rösch]

Hi all,

I had some problem when using your e1000-code on a MIPS target.
Attached you will find two fixes which I would like to propose for
discussion.

- Fix 1: this has the same reason as in commit
f81ecb5d3300bf92d17302d3712f30585c182da9

- Fix 2: has to do with "C Language Operator Precedence".
I would say the expression taken by the ! operator has precedence before
the & operator.
So any bit in rd->status other than E1000_RXD_STAT_DD stops correct
detection of data reception.
(What i do not know is, if it is possible that any other bit than
E1000_RXD_STAT_DD can get active)

Please leave me in CC, because i'm not subscribed to this list.

Thanks a lot for providing u-boot.

Best regards
Ralf

-- 
Roesch & Walter___________________________________________
Industrie-Elektronik GmbH * Tel.: +49-7824 / 6628-0
W?rtelweg 2b/c            * Fax:  +49-7824 / 6628-29
D-77963 Schwanau          * mailto:ralf.roesch at rw-gmbh.de
Germany                   * WWW: http://www.rw-gmbh.de
Amtsgericht Freiburg i.Br. HRB 391345
Gesch?ftsf?hrer: Dipl.Ing.(FH) Ralf R?sch, Dipl.Ing.(FH) Martin Walter

GnuPG key: 52ECD70F 2010-09-04 [expires: 2012-12-31]
Fingerprint: 8415 9113 5F05 D579 6685  D5AD 5CE7 5429 52EC D70F