From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Fri, 27 Jan 2012 14:56:52 -0700 Subject: [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021 In-Reply-To: <201201262154.02374.vapier@gentoo.org> References: <1327616505-11669-1-git-send-email-troy.kisky@boundarydevices.com> <1327616505-11669-3-git-send-email-troy.kisky@boundarydevices.com> <201201262154.02374.vapier@gentoo.org> Message-ID: <4F231DA4.7020304@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 1/26/2012 7:54 PM, Mike Frysinger wrote: > On Thursday 26 January 2012 17:21:44 Troy Kisky wrote: >> +/* This is used to set board specific things like clock skew */ >> +unsigned short ksz9021_por_cmds[] = { > static const Thanks > >> +int ksz9021_send_phy_cmds(struct phy_device *phydev, unsigned short* p) > static Thanks > >> + for (;;) { > personally, i'd prefer: > while (1) { > -mike I used to prefer while (1), but then Microsoft started warning about it. I doubt GCC ever makes the same decision, but it is easier to use the same style. And I can't see a downside. see http://msdn.microsoft.com/en-us/library/6t66728h%28VS.80%29.aspx