[U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

[Igor Grinberg <grinberg@compulab.co.il>]

Hi Stefano,

On 01/29/12 13:42, Stefano Babic wrote:
> On 29/01/2012 10:42, Igor Grinberg wrote:
>> Hi Govindraj,
>>
> 
> Hi all,
> 
>> Put Remy on Cc.
> 
> Remy resigned as USB maintainer - but Tom is aware about these patches...

Right. This patch touches the USB subsystem, therefore I put Remy in Cc.

> 
>>
>> Note: my new mail client for some reason, messes with white spaces...
>> (Thunderbird (9) just gets better and better...)
> 
> I had the opposite problem - this patch from patchwork is messy.
> Patchworks mixed some answer with the patch and it is not appliable. But
> using Thunderbird 9 I had no problem...
> 
>> So, please ignore those.
>> BTW, is there anyone who has those issues fixed and can save me a wasted
>> hour?
> 
> I do not know exactly your problem, but I pushed my tree for TAM3517 on
> 
> 	git.denx.de/u-boot-imx, spl_linux_twister branch
> 
> Maybe this can help you

Thanks, actually it turned out to be some kind of dynamic libraries problem
that Thunderbird uses (probably spelling libraries...), so reinstalling
Thunderbird along with all libraries it depends on, did the trick.

> 
>>> diff --git a/include/configs/omap4_panda.h
>>> b/include/configs/omap4_panda.h
>>> index 23c0230..0228a66 100644
>>> --- a/include/configs/omap4_panda.h
>>> +++ b/include/configs/omap4_panda.h
>>> @@ -38,6 +38,8 @@
>>>   #define CONFIG_USB_HOST
>>>   #define CONFIG_USB_EHCI
>>>   #define CONFIG_USB_EHCI_OMAP
>>> +#define CONFIG_USB_ULPI
>>> +#define CONFIG_USB_OMAP_ULPI_VIEWPORT
>>>   #define CONFIG_USB_STORAGE
>>>   #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
>>
>> This also should apply for TAM3517 board.
>> Stefano, can you test this on TAM3517?
> 
> Tested on twister / TAM3517, I can read a USB pen.
> 
> Tested-by: Stefano Babic <sbabic@denx.de>

Thanks for testing!

Govidraj, can the "enabling the ULPI for boards" reside
in a separate patch and also include the boards that were
tested with it (e.g. TAM3517)?

Thanks.


-- 
Regards,
Igor.