From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 5/5] i.mx6q: mx6qsabrelite: Update the network configuration
Date: Wed, 01 Feb 2012 18:37:46 -0700 [thread overview]
Message-ID: <4F29E8EA.80602@boundarydevices.com> (raw)
In-Reply-To: <1328145288-23406-5-git-send-email-troy.kisky@boundarydevices.com>
On 2/1/2012 6:14 PM, Troy Kisky wrote:
> + ksz9021_phy_write(phydev, 0, 0x105, 0x0); /* min rx data delay */
> + ksz9021_phy_write(phydev, 0, 0x106, 0x0); /* min tx data delay */
> + /* max rx/tx clock delay, min rx/tx control */
> + ksz9021_phy_write(phydev, 0, 0x104, 0xf0f0);
> + if (phydev->drv->config)
> + phydev->drv->config(phydev);
>
I didn't notice this warning before
mx6qsabrelite.c:244: warning: implicit declaration of function
'ksz9021_phy_write'
Can I add this definition to mx6qsabrelite.c?
checkpatch says it should be in a .h file.
I'll resend just 5/5 if nobody spots other issues.
Troy
next prev parent reply other threads:[~2012-02-02 1:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 1:14 [U-Boot] [PATCH v3 1/5] net: fec_mxc: add 1000 Mbps selection Troy Kisky
2012-02-02 1:14 ` [U-Boot] [PATCH v3 2/5] net: fec_mxc: add PHYLIB support Troy Kisky
2012-02-02 1:14 ` [U-Boot] [PATCH v3 3/5] net: phy: add support for Micrel's KSZ9021 Troy Kisky
2012-02-02 1:14 ` [U-Boot] [PATCH v3 4/5] net: phy: make board_phy_config responsible for calling drv->config Troy Kisky
2012-02-02 1:14 ` [U-Boot] [PATCH v3 5/5] i.mx6q: mx6qsabrelite: Update the network configuration Troy Kisky
2012-02-02 1:37 ` Troy Kisky [this message]
2012-02-02 2:41 ` Jason Hui
2012-02-02 1:25 ` [U-Boot] [PATCH v3 1/5] net: fec_mxc: add 1000 Mbps selection Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F29E8EA.80602@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox