From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Wed, 01 Feb 2012 18:37:46 -0700 Subject: [U-Boot] [PATCH v3 5/5] i.mx6q: mx6qsabrelite: Update the network configuration In-Reply-To: <1328145288-23406-5-git-send-email-troy.kisky@boundarydevices.com> References: <1328145288-23406-1-git-send-email-troy.kisky@boundarydevices.com> <1328145288-23406-5-git-send-email-troy.kisky@boundarydevices.com> Message-ID: <4F29E8EA.80602@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2/1/2012 6:14 PM, Troy Kisky wrote: > + ksz9021_phy_write(phydev, 0, 0x105, 0x0); /* min rx data delay */ > + ksz9021_phy_write(phydev, 0, 0x106, 0x0); /* min tx data delay */ > + /* max rx/tx clock delay, min rx/tx control */ > + ksz9021_phy_write(phydev, 0, 0x104, 0xf0f0); > + if (phydev->drv->config) > + phydev->drv->config(phydev); > I didn't notice this warning before mx6qsabrelite.c:244: warning: implicit declaration of function 'ksz9021_phy_write' Can I add this definition to mx6qsabrelite.c? checkpatch says it should be in a .h file. I'll resend just 5/5 if nobody spots other issues. Troy