From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 10/18] tegra: usb: fdt: Add additional device tree definitions for USB ports
Date: Thu, 02 Feb 2012 15:07:03 -0700 [thread overview]
Message-ID: <4F2B0907.8050708@nvidia.com> (raw)
In-Reply-To: <1327447272-30182-11-git-send-email-sjg@chromium.org>
On 01/24/2012 04:21 PM, Simon Glass wrote:
> This adds clock references to the USB part of the device tree for U-Boot.
>
> The USB timing information may vary between boards sometimes, but for
> now we hard-code it in C. This is because all current T2x boards use
> the same values, we will deal with T3x later and we first need to agree
> on the format for this timing information in the fdt and may in fact
> decide that it has no place there.
The patch below does more than what's covered by this description...
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v5:
> - Add dr_mode property to control host/device/otg mode
> - Add nvidia,has-legacy-mode property per review comments
> - Change device tree comment style from // to /* */
>
> arch/arm/dts/tegra20.dtsi | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> index ec75747..b2e3a40 100644
> --- a/arch/arm/dts/tegra20.dtsi
> +++ b/arch/arm/dts/tegra20.dtsi
> @@ -176,6 +176,9 @@
> reg = <0xc5000000 0x4000>;
> interrupts = < 52 >;
> phy_type = "utmi";
> + clocks = <&periph_clk 22>; /* PERIPH_ID_USBD */
> + dr_mode = "otg";
The dr_mode value is board-specific, so should be in tegra-seaboard.dts
not tegra20.dtsi.
For example, on true Seaboard, perhaps USB3 could operate in "otg" mode
since it's an external port, whereas on Springbank, USB3 is hard-wired
to a keyboard controller, so should be marked "host" mode only.
Related, I assume that any port marked as "otg" needs to have a VBUS
GPIO defined so that it can be turned off in device mode, or is VBUS
controlled by some other mechanism in some cases? Given that, I /think/
you can't actually mark USB3 as "otg" or "device" on Seaboard since
there's no VBUS GPIO.
--
nvpublic
next prev parent reply other threads:[~2012-02-02 22:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 23:20 [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver Simon Glass
2012-01-24 23:20 ` [U-Boot] [PATCH v5 01/18] fdt: Add basic support for decoding GPIO definitions Simon Glass
2012-01-24 23:20 ` [U-Boot] [PATCH v5 02/18] arm: fdt: Ensure that an embedded fdt is word-aligned Simon Glass
2012-01-24 23:20 ` [U-Boot] [PATCH v5 03/18] arm: fdt: Add skeleton device tree file from kernel Simon Glass
2012-01-24 23:20 ` [U-Boot] [PATCH v5 04/18] tegra: fdt: Add Tegra2x " Simon Glass
2012-01-24 23:20 ` [U-Boot] [PATCH v5 05/18] tegra: fdt: Add device tree file for Tegra2 Seaboard " Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 06/18] fdt: Add staging area for device tree binding documentation Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 07/18] fdt: Add tegra-usb bindings file from linux Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 08/18] tegra: fdt: Add additional USB binding Simon Glass
2012-02-02 21:55 ` Stephen Warren
2012-02-03 16:58 ` Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 09/18] tegra: fdt: Add clock bindings Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 10/18] tegra: usb: fdt: Add additional device tree definitions for USB ports Simon Glass
2012-02-02 22:07 ` Stephen Warren [this message]
2012-02-03 17:04 ` Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 11/18] tegra: usb: fdt: Add USB definitions for Tegra2 Seaboard Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 12/18] usb: Add support for txfifo threshold Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 13/18] fdt: Add function to return peripheral/clock ID Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 14/18] tegra: usb: Add support for Tegra USB peripheral Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 15/18] tegra: usb: Add USB support to nvidia boards Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 16/18] tegra: usb: Add common USB defines for tegra2 boards Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 17/18] tegra: usb: Enable USB on Seaboard Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 18/18] tegra: fdt: Enable FDT support for Seaboard Simon Glass
2012-02-02 22:17 ` Stephen Warren
2012-02-03 17:05 ` Simon Glass
2012-02-26 23:13 ` [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver Marek Vasut
2012-02-27 3:02 ` Simon Glass
2012-02-27 20:49 ` Simon Glass
2012-02-27 20:55 ` Marek Vasut
2012-02-27 21:44 ` Tom Warren
2012-02-27 21:46 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2B0907.8050708@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox