From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 03 Feb 2012 17:14:16 -0700 Subject: [U-Boot] [PATCH v2 6/7] tegra: Select I2C ordering for Seaboard In-Reply-To: References: <1326394818-32227-1-git-send-email-sjg@chromium.org> <1326394818-32227-7-git-send-email-sjg@chromium.org> <4F188384.1030305@nvidia.com> Message-ID: <4F2C7858.6070307@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/03/2012 04:24 PM, Simon Glass wrote: > Hi Stephen, > > On Thu, Jan 19, 2012 at 12:56 PM, Stephen Warren wrote: >> On 01/12/2012 12:00 PM, Simon Glass wrote: >>> Select the port ordering for I2C on Seaboard. >>> >>> Signed-off-by: Simon Glass >>> Acked-by: Stephen Warren >> >> This isn't the patch that I ack'd. > > Sorry, I added the disable. > >> >>> diff --git a/board/nvidia/dts/tegra2-seaboard.dts b/board/nvidia/dts/tegra2-seaboard.dts >> >> Unrelated to this patch, but shouldn't that be tegra-seaboard.dts not >> tegra2-seaboard.dts to match the naming in the kernel? >> >>> @@ -44,4 +49,9 @@ >>> usb at c5004000 { >>> status = "disabled"; >>> }; >>> + >>> + i2c at 7000c400 { >>> + status = "disabled"; >>> + }; >>> + >>> }; >> >> That chunk wasn't in the original patch, and doesn't match the kernel's >> .dts file (and I believe that I2C controller really is in use, so >> shouldn't be disabled). > > It cannot be used - remember the discussion about pinmux? We elected > to disable I2C1 at present since you didn't like my nvidia,pinmux > binding for selecting which value to pass to funcmux. The fix is to > pass 1 instead of 0 for that port, but we have no clean way to specify > this. > > Rather disable it than leave it enabled and not working. Rather than having the .dts file not correctly describe the HW, wouldn't it be better to limit U-Boot's to only initializing the 1 I2C controller that it knows the valid pinmux setting for? -- nvpublic