From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 6/7] tegra: Select I2C ordering for Seaboard
Date: Fri, 03 Feb 2012 17:25:24 -0700 [thread overview]
Message-ID: <4F2C7AF4.1000605@nvidia.com> (raw)
In-Reply-To: <CAPnjgZ1GcOkNKOoWRL_iX-e6UGzX7dqkT44=HpBUWo42aGKGUg@mail.gmail.com>
On 02/03/2012 05:19 PM, Simon Glass wrote:
> Hi Stephen,
>
> On Fri, Feb 3, 2012 at 4:14 PM, Stephen Warren <swarren@nvidia.com> wrote:
>> On 02/03/2012 04:24 PM, Simon Glass wrote:
>>> Hi Stephen,
>>>
>>> On Thu, Jan 19, 2012 at 12:56 PM, Stephen Warren <swarren@nvidia.com> wrote:
>>>> On 01/12/2012 12:00 PM, Simon Glass wrote:
>>>>> Select the port ordering for I2C on Seaboard.
>>>>>
>>>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>>>> Acked-by: Stephen Warren <swarren@nvidia.com>
>>>>
>>>> This isn't the patch that I ack'd.
>>>
>>> Sorry, I added the disable.
>>>
>>>>
>>>>> diff --git a/board/nvidia/dts/tegra2-seaboard.dts b/board/nvidia/dts/tegra2-seaboard.dts
>>>>
>>>> Unrelated to this patch, but shouldn't that be tegra-seaboard.dts not
>>>> tegra2-seaboard.dts to match the naming in the kernel?
>>>>
>>>>> @@ -44,4 +49,9 @@
>>>>> usb at c5004000 {
>>>>> status = "disabled";
>>>>> };
>>>>> +
>>>>> + i2c at 7000c400 {
>>>>> + status = "disabled";
>>>>> + };
>>>>> +
>>>>> };
>>>>
>>>> That chunk wasn't in the original patch, and doesn't match the kernel's
>>>> .dts file (and I believe that I2C controller really is in use, so
>>>> shouldn't be disabled).
>>>
>>> It cannot be used - remember the discussion about pinmux? We elected
>>> to disable I2C1 at present since you didn't like my nvidia,pinmux
>>> binding for selecting which value to pass to funcmux. The fix is to
>>> pass 1 instead of 0 for that port, but we have no clean way to specify
>>> this.
>>>
>>> Rather disable it than leave it enabled and not working.
>>
>> Rather than having the .dts file not correctly describe the HW, wouldn't
>> it be better to limit U-Boot's to only initializing the 1 I2C controller
>> that it knows the valid pinmux setting for?
>
> Well, on Seaboard I2C2 (sorry, not I2C1 as I said in my email) is not
> used or connected to anything, so it is a reasonable description of
> the hardware. The other 3 pinmux settings are valid.
As best I can tell from my schematics, all 4 I2C ports are used on both
Seaboard and Springbank.
--
nvpublic
next prev parent reply other threads:[~2012-02-04 0:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 19:00 [U-Boot] [PATCH v2 0/7] tegra: Add I2C driver and associated parts Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 1/7] tegra: Rename NV_PA_PMC_BASE to TEGRA2_PMC_BASE Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 2/7] fdt: Add function to allow aliases to refer to multiple nodes Simon Glass
2012-01-19 20:49 ` Stephen Warren
2012-01-19 23:45 ` Simon Glass
2012-01-20 0:17 ` Stephen Warren
2012-01-20 0:31 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 3/7] tegra: fdt: Add extra I2C bindings for U-Boot Simon Glass
2012-01-13 6:31 ` Heiko Schocher
2012-01-13 15:02 ` Simon Glass
2012-01-19 20:51 ` Stephen Warren
2012-01-22 17:41 ` Simon Glass
2012-01-23 18:25 ` Stephen Warren
2012-02-03 23:27 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 4/7] tegra: Add I2C driver Simon Glass
2012-01-13 7:25 ` Heiko Schocher
2012-01-13 15:09 ` Simon Glass
2012-01-13 15:15 ` Heiko Schocher
2012-01-19 21:08 ` Stephen Warren
2012-02-03 23:26 ` Simon Glass
2012-02-06 21:41 ` Yen Lin
2012-02-09 17:46 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 5/7] tegra: Initialise I2C on Nvidia boards Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 6/7] tegra: Select I2C ordering for Seaboard Simon Glass
2012-01-19 20:56 ` Stephen Warren
2012-02-03 23:24 ` Simon Glass
2012-02-04 0:14 ` Stephen Warren
2012-02-04 0:19 ` Simon Glass
2012-02-04 0:25 ` Stephen Warren [this message]
2012-02-04 0:36 ` Simon Glass
2012-02-04 0:41 ` Stephen Warren
2012-02-04 0:58 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 7/7] tegra: Enable I2C on Seaboard Simon Glass
2012-01-13 6:28 ` [U-Boot] [PATCH v2 0/7] tegra: Add I2C driver and associated parts Heiko Schocher
2012-01-13 15:01 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2C7AF4.1000605@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox