From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Mon, 06 Feb 2012 14:42:07 +0200
Subject: [U-Boot] [PATCH V7] mcx: support for HTKW mcx board
In-Reply-To: <1328453859-10070-1-git-send-email-sbabic@denx.de>
References: <1323878756-18727-1-git-send-email-yanok@emcraft.com>
	<1328453859-10070-1-git-send-email-sbabic@denx.de>
Message-ID: <4F2FCA9F.1040003@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,

Cc'd Govindraj.

On 02/05/12 16:57, Stefano Babic wrote:
> From: Ilya Yanok <yanok@emcraft.com>
> 
> This patch adds support for the HTKW mcx AM3517-based board.
> Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both
> NAND and MMC SPLs are supported.
> 
> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Tom Rini <tom.rini@gmail.com>
> Cc: Detlev Zundel <dzu@denx.de>

[...]

> diff --git a/board/htkw/mcx/mcx.c b/board/htkw/mcx/mcx.c
> new file mode 100644
> index 0000000..dcc8707
> --- /dev/null
> +++ b/board/htkw/mcx/mcx.c

[...]

> +#ifdef CONFIG_USB_EHCI
> +static struct omap_usbhs_board_data usbhs_bdata = {
> +	.port_mode[0] = OMAP_EHCI_PORT_MODE_PHY,
> +	.port_mode[1] = OMAP_EHCI_PORT_MODE_PHY,
> +	.port_mode[2] = OMAP_EHCI_PORT_MODE_PHY,

This looks wrong, as port3 is TLL only, so it cannot have a PHY,
or am I missing something?

> +};
> +
> +int ehci_hcd_init(void)
> +{
> +	int ret;
> +
> +	ret = omap_ehci_hcd_init(&usbhs_bdata);
> +	if (ret < 0)
> +		return ret;
> +
> +	return 0;
> +}

return omap_ehci_hcd_init(&usbhs_bdata);
?

> +
> +int ehci_hcd_stop(void)
> +{
> +	int ret;
> +
> +	ret = omap_ehci_hcd_stop();
> +	return ret;
> +}

same here:
return omap_ehci_hcd_stop();
?

[...]


-- 
Regards,
Igor.