public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6qarm2: fix build error for board_mmc_getcd()
Date: Mon, 6 Feb 2012 14:00:34 +0100	[thread overview]
Message-ID: <4F2FCEF2.6090408@de.bosch.com> (raw)
In-Reply-To: <1328532854-21510-1-git-send-email-prabhakar.csengg@gmail.com>

On 06.02.2012 13:54, Prabhakar Lad wrote:
> Fix build error for mx6qarm2 board due to prototype change
> for function  board_mmc_getcd().
> mx6qarm2.c:123: error: conflicting types for 'board_mmc_getcd'
> u-boot/include/mmc.h:318: note: previous declaration of 'board_mmc_getcd' was here
> 
> Signed-off-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
> ---
>  board/freescale/mx6qarm2/mx6qarm2.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/board/freescale/mx6qarm2/mx6qarm2.c b/board/freescale/mx6qarm2/mx6qarm2.c
> index 9894245..2cb37dd 100644
> --- a/board/freescale/mx6qarm2/mx6qarm2.c
> +++ b/board/freescale/mx6qarm2/mx6qarm2.c
> @@ -120,17 +120,17 @@ struct fsl_esdhc_cfg usdhc_cfg[2] = {
>  	{USDHC4_BASE_ADDR, 1},
>  };
>  
> -int board_mmc_getcd(u8 *cd, struct mmc *mmc)
> +int board_mmc_getcd(struct mmc *mmc)
>  {
>  	struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
> +	int ret = 0;
>  
>  	if (cfg->esdhc_base == USDHC3_BASE_ADDR) {
>  		gpio_direction_input(171); /*GPIO6_11*/
> -		*cd = gpio_get_value(171);
> -	} else /* Don't have the CD GPIO pin on board */
> -		*cd = 0;
> +		ret = !gpio_get_value(171);
> +	}
>  
> -	return 0;
> +	return ret;
>  }
>  
>  int board_mmc_init(bd_t *bis)

This should be fixed already at u-boot-imx.git:

http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=e669db1c209eed02ca8c837914c161f5daa2d8fd

Please check.

Best regards

Dirk

  reply	other threads:[~2012-02-06 13:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 12:54 [U-Boot] [PATCH] mx6qarm2: fix build error for board_mmc_getcd() Prabhakar Lad
2012-02-06 13:00 ` Dirk Behme [this message]
2012-02-06 13:07   ` Prabhakar Lad
2012-02-06 13:39 ` Thierry Reding
2012-02-06 14:03   ` Prabhakar Lad
2012-02-06 14:14     ` Thierry Reding
2012-02-07  5:00       ` Prabhakar Lad
2012-02-07  7:22         ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2FCEF2.6090408@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox