public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] RFC: Let linker create phy array
Date: Mon, 06 Feb 2012 21:56:08 +0100	[thread overview]
Message-ID: <4F303E68.3050706@aribaud.net> (raw)
In-Reply-To: <4F30355C.7060908@boundarydevices.com>

Le 06/02/2012 21:17, Troy Kisky a ?crit :
> On 2/6/2012 12:07 PM, Mike Frysinger wrote:
>> On Monday 06 February 2012 13:48:13 Troy Kisky wrote:
>>> On 2/4/2012 8:38 PM, Mike Frysinger wrote:
>>>> On Saturday 04 February 2012 22:02:46 Troy Kisky wrote:
>>>>> --- a/drivers/net/phy/broadcom.c
>>>>> +++ b/drivers/net/phy/broadcom.c
>>>>>
>>>>> -static struct phy_driver BCM5461S_driver = {
>>>>> +struct phy_driver BCM5461S_driver __phy_entry = {
>>>> why do you have to remove the static ? that shouldn't affect the
>>>> section
>>>> name that it gets placed into.
>>> I had static to start. But the compiler ate all of the code. No
>>> references to any of the static symbols.
>> sounds like you should change the __phy_entry define from "unused" to
>> "used"
>> -mike
> The would give me compiler warnings for unused variables. How does that
> help?
> Is there a keep attribute like the linker has for sections?

No, but indeed not keeping the 'static' keyword has this effect: the 
object file will keep the phy struct, in case it is referred to by 
another object file at link time.

> Troy

Amicalement,
-- 
Albert.

  reply	other threads:[~2012-02-06 20:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-05  3:02 [U-Boot] [PATCH 1/2] RFC: create u-boot-common.lds Troy Kisky
2012-02-05  3:02 ` [U-Boot] [PATCH 2/2] RFC: Let linker create phy array Troy Kisky
2012-02-05  3:38   ` Mike Frysinger
2012-02-05  6:16     ` Dirk Behme
2012-02-05 13:26     ` Albert ARIBAUD
2012-02-05 20:40       ` Mike Frysinger
2012-02-06 20:53         ` Albert ARIBAUD
2012-02-06 18:48     ` Troy Kisky
2012-02-06 19:07       ` Mike Frysinger
2012-02-06 20:17         ` Troy Kisky
2012-02-06 20:56           ` Albert ARIBAUD [this message]
2012-02-06 20:57           ` Mike Frysinger
2012-02-06 21:01             ` Albert ARIBAUD
2012-02-07 15:20               ` Mike Frysinger
2012-02-10 19:39                 ` Albert ARIBAUD
2012-02-10 20:32                   ` Mike Frysinger
2012-02-10 20:57                     ` Albert ARIBAUD
2012-02-10 21:41                       ` Mike Frysinger
2012-02-12 14:45                         ` Albert ARIBAUD
2012-02-06 21:44             ` Troy Kisky
2012-02-07 15:21               ` Mike Frysinger
2012-02-05 21:01 ` [U-Boot] [PATCH 1/2] RFC: create u-boot-common.lds Mike Frysinger
2012-02-05 22:07   ` Graeme Russ
2012-02-06  3:24     ` Mike Frysinger
2012-02-06  3:43       ` Graeme Russ
2012-02-06  4:27         ` Mike Frysinger
2012-02-06  4:34           ` Graeme Russ
2012-02-06  5:48             ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F303E68.3050706@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox