From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 06 Feb 2012 22:06:24 +0100 Subject: [U-Boot] [RFC PATCH 2/4] OMAP3+: fix issues with Thumb build In-Reply-To: <1328528248-20872-3-git-send-email-aneesh@ti.com> References: <1328528248-20872-1-git-send-email-aneesh@ti.com> <1328528248-20872-3-git-send-email-aneesh@ti.com> Message-ID: <4F3040D0.5070808@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 06/02/2012 12:37, Aneesh V a ?crit : > When U-Boot/SPL is built using the Thumb instruction set the > toolchain has a potential issue with weakly linked symbols. > If a function has a weakly linked default implementation in C > and a real implementation in assembly GCC is confused about the > instruction set of the assembly implementation. As a result > the assembly function that is built in ARM is executed as > if it is Thumb. This results in a crash. > > We need to investigate further to see if this is a toolchain > issue or an issue with our usage of it. In the meanwhile, we > can workaround the issue by having both the weakly linked alias > and the real implementation in C. I would tend to NAK a patch submission where an issue is known and investigation is considered but is actually bypassed by a workaround. These tend to turn from 'temporary fix' to 'old crust' with time, because there is no incentive for a better solution when the quick fix "works, after all". Amicalement, -- Albert.