[U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?

[U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?

[Albert ARIBAUD]

Hi,

Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/ 
which adds HUSH parser to ED Mini V2. In itself, the change is only made 
of three CONFIG defines.

This patch has built cleanly and worked as expected until 
http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both 
patches causes edminiv2 build to fail with

uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2
Configuring for edminiv2 board...
common/libcommon.o: In function `cread_line':
/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to 
`get_ticks'
/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to 
`get_tbclk'
/home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to 
`get_ticks'

Heiko, can you look this up?

Amicalement,
-- 
Albert.

[U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?

[Stefano Babic]

On 06/02/2012 23:43, Albert ARIBAUD wrote:
> Hi,
> 

Hi Albert,

> Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/
> which adds HUSH parser to ED Mini V2. In itself, the change is only made
> of three CONFIG defines.
> 
> This patch has built cleanly and worked as expected until
> http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both
> patches causes edminiv2 build to fail with
> 
> uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2
> Configuring for edminiv2 board...
> common/libcommon.o: In function `cread_line':
> /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> `get_ticks'
> /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> `get_tbclk'
> /home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to
> `get_ticks'

This is not a problem in your patch, but some SOCs have no
implementation of the new and now accepted iunterface. I have sent
patches for i.MX35/i.mx5/i.mx31:
	http://patchwork.ozlabs.org/patch/139718/

I have seen that other SOCs have the same issue, while kirchwood has
introduced an empty implementation for such functions. We should fix all
remaining arch.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?

[Prafulla Wadaskar]

Even I am facing this problem.
I have applied the patches to be mainlined to u-boot-marvell.git (tobe send for pull request) but my build is failing due to same issue.

Regards..
Prafulla . . .

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> bounces at lists.denx.de] On Behalf Of Albert ARIBAUD
> Sent: 07 February 2012 04:13
> To: Heiko Schocher
> Cc: U-Boot
> Subject: [U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to
> break HUSH parser?
> 
> Hi,
> 
> Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/
> which adds HUSH parser to ED Mini V2. In itself, the change is only
> made
> of three CONFIG defines.
> 
> This patch has built cleanly and worked as expected until
> http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both
> patches causes edminiv2 build to fail with
> 
> uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2
> Configuring for edminiv2 board...
> common/libcommon.o: In function `cread_line':
> /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> `get_ticks'
> /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> `get_tbclk'
> /home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to
> `get_ticks'
> 
> Heiko, can you look this up?
> 
> Amicalement,
> --
> Albert.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?

[Prafulla Wadaskar]

Hi Albert/Heiko

I have posted the patch for this fix for all ARM Marvell SoCs.
Will include it and post the pull request.

Regards..
Prafulla . . .

> -----Original Message-----
> From: Prafulla Wadaskar
> Sent: 08 February 2012 02:40
> To: 'Albert ARIBAUD'; Heiko Schocher
> Cc: U-Boot
> Subject: RE: [U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems
> to break HUSH parser?
> 
> Even I am facing this problem.
> I have applied the patches to be mainlined to u-boot-marvell.git (tobe
> send for pull request) but my build is failing due to same issue.
> 
> Regards..
> Prafulla . . .
> 
> > -----Original Message-----
> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> > bounces at lists.denx.de] On Behalf Of Albert ARIBAUD
> > Sent: 07 February 2012 04:13
> > To: Heiko Schocher
> > Cc: U-Boot
> > Subject: [U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to
> > break HUSH parser?
> >
> > Hi,
> >
> > Some time ago I have posted
> http://patchwork.ozlabs.org/patch/136368/
> > which adds HUSH parser to ED Mini V2. In itself, the change is only
> > made
> > of three CONFIG defines.
> >
> > This patch has built cleanly and worked as expected until
> > http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both
> > patches causes edminiv2 build to fail with
> >
> > uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2
> > Configuring for edminiv2 board...
> > common/libcommon.o: In function `cread_line':
> > /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> > `get_ticks'
> > /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> > `get_tbclk'
> > /home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to
> > `get_ticks'
> >
> > Heiko, can you look this up?
> >
> > Amicalement,
> > --
> > Albert.
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?

[Heiko Schocher]

Hello Stefano,

Stefano Babic wrote:
> On 06/02/2012 23:43, Albert ARIBAUD wrote:
>> Hi,
>>
> 
> Hi Albert,
> 
>> Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/
>> which adds HUSH parser to ED Mini V2. In itself, the change is only made
>> of three CONFIG defines.
>>
>> This patch has built cleanly and worked as expected until
>> http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both
>> patches causes edminiv2 build to fail with
>>
>> uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2
>> Configuring for edminiv2 board...
>> common/libcommon.o: In function `cread_line':
>> /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
>> `get_ticks'
>> /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
>> `get_tbclk'
>> /home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to
>> `get_ticks'
> 
> This is not a problem in your patch, but some SOCs have no
> implementation of the new and now accepted iunterface. I have sent

Yep, exactly!

> patches for i.MX35/i.mx5/i.mx31:
> 	http://patchwork.ozlabs.org/patch/139718/

Thanks!

> I have seen that other SOCs have the same issue, while kirchwood has
> introduced an empty implementation for such functions. We should fix all
> remaining arch.

Yes.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany