public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3: TAM3517: update ehci interface
Date: Tue, 07 Feb 2012 16:13:01 +0100	[thread overview]
Message-ID: <4F313F7D.5050902@denx.de> (raw)
In-Reply-To: <4F2FE9E1.2070601@compulab.co.il>

On 06/02/2012 15:55, Igor Grinberg wrote:
> Hi Stefano,
> 

Hi Igor,

>> +#ifdef CONFIG_USB_EHCI
>> +
>> +static struct omap_usbhs_board_data usbhs_bdata = {
>> +	.port_mode[0] = OMAP_EHCI_PORT_MODE_PHY,
>> +	.port_mode[1] = OMAP_EHCI_PORT_MODE_PHY,
>> +	.port_mode[2] = OMAP_EHCI_PORT_MODE_PHY,
>> +};
> 
> OMAP EHCI port3 is TLL only, so the above does not look right...

This is a strange effect. I have tested setting OMAP_EHCI_PORT_MODE_PHY
(of course the phy is on another port), and everything works. However,
after setting port_mode[2] to OMAP_USBHS_PORT_MODE_NONE, it does not
work anymore and no storage are detected. I have not an explanation,
maybe some of you can give some hints. Really, the change should have no
effect...

> 
> return omap_ehci_hcd_init(&usbhs_bdata);

Right, I'll fix

> 
> return omap_ehci_hcd_stop();

I fix this, too

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2012-02-07 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-04  8:07 [U-Boot] [PATCH] OMAP3: TAM3517: update ehci interface Stefano Babic
2012-02-06 14:55 ` Igor Grinberg
2012-02-07 15:13   ` Stefano Babic [this message]
2012-02-07 15:33     ` Stefano Babic
2012-02-08  6:06       ` Govindraj
2012-02-08  8:03         ` Stefano Babic
2012-02-08  9:28 ` [U-Boot] [PATCH V2] " Stefano Babic
2012-02-08 10:08   ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F313F7D.5050902@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox