From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Tue, 07 Feb 2012 16:13:01 +0100
Subject: [U-Boot] [PATCH] OMAP3: TAM3517: update ehci interface
In-Reply-To: <4F2FE9E1.2070601@compulab.co.il>
References: <1328342869-13347-1-git-send-email-sbabic@denx.de>
	<4F2FE9E1.2070601@compulab.co.il>
Message-ID: <4F313F7D.5050902@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/02/2012 15:55, Igor Grinberg wrote:
> Hi Stefano,
> 

Hi Igor,

>> +#ifdef CONFIG_USB_EHCI
>> +
>> +static struct omap_usbhs_board_data usbhs_bdata = {
>> +	.port_mode[0] = OMAP_EHCI_PORT_MODE_PHY,
>> +	.port_mode[1] = OMAP_EHCI_PORT_MODE_PHY,
>> +	.port_mode[2] = OMAP_EHCI_PORT_MODE_PHY,
>> +};
> 
> OMAP EHCI port3 is TLL only, so the above does not look right...

This is a strange effect. I have tested setting OMAP_EHCI_PORT_MODE_PHY
(of course the phy is on another port), and everything works. However,
after setting port_mode[2] to OMAP_USBHS_PORT_MODE_NONE, it does not
work anymore and no storage are detected. I have not an explanation,
maybe some of you can give some hints. Really, the change should have no
effect...

> 
> return omap_ehci_hcd_init(&usbhs_bdata);

Right, I'll fix

> 
> return omap_ehci_hcd_stop();

I fix this, too

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================