From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 08 Feb 2012 14:17:26 +0100 Subject: [U-Boot] [PATCH 1/5] mx53loco: Use gpio_direction_input prior to gpio_get_value In-Reply-To: References: <1328704485-1505-1-git-send-email-festevam@gmail.com> <4F3273E8.9040003@denx.de> Message-ID: <4F3275E6.1060409@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/02/2012 14:14, Fabio Estevam wrote: > On Wed, Feb 8, 2012 at 11:08 AM, Stefano Babic wrote: > >> The patch makes clear that the GPIO is configured as input. However, >> after a reset all GPIOs in the MX53 are configured as input. Do we need >> such changes ? > > I would prefer to explicitly set gpio_direction_input rather than > depending on the reset value and I think it aligns with the GPIO API > mechanism used in the kernel as well. Ok, good reasons. Acked-by: Stefano Babic Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================