From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Thu, 09 Feb 2012 09:09:52 +0100
Subject: [U-Boot] [PATCH 2/2] mx6qsabrelite: add and enable USB Host 1
 support
In-Reply-To: <4F33732E.6050500@de.bosch.com>
References: <1328714608-4888-1-git-send-email-wg@denx.de>	<1328714608-4888-3-git-send-email-wg@denx.de>
	<4F33732E.6050500@de.bosch.com>
Message-ID: <4F337F50.4030902@grandegger.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Dirk,

On 02/09/2012 08:18 AM, Dirk Behme wrote:
> Hi Wolfgang,
> 
> On 08.02.2012 16:23, Wolfgang Grandegger wrote:
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Jason Liu <jason.hui@linaro.org>
>> Signed-off-by: Wolfgang Grandegger <wg@denx.de>
>> ---
>>  board/freescale/mx6qsabrelite/mx6qsabrelite.c |   12 ++++++++++++
>>  include/configs/mx6qsabrelite.h               |   15 +++++++++++++++
>>  2 files changed, 27 insertions(+), 0 deletions(-)
>>
>> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> index 4028789..01ecec4 100644
>> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> @@ -77,6 +77,18 @@ static void setup_iomux_uart(void)
>>         imx_iomux_v3_setup_multiple_pads(uart2_pads,
>> ARRAY_SIZE(uart2_pads));
>>  }
>>  
>> +#ifdef CONFIG_USB_EHCI_MX6
>> +int board_ehci_hcd_init(int port)
>> +{
>> +    imx_iomux_v3_setup_multiple_pads(usb_pads, ARRAY_SIZE(usb_pads));
> 
> Where is the definition of 'usb_pads'?

Oops, that hunk gets lost when rebasing to head of u-boot-imx in a hurry:

@@ -122,6 +122,10 @@ iomux_v3_cfg_t enet_pads2[] = {
        MX6Q_PAD_RGMII_RX_CTL__RGMII_RX_CTL     | MUX_PAD_CTRL(ENET_PAD_CTRL),
 };
 
+iomux_v3_cfg_t usb_pads[] = {
+       MX6Q_PAD_GPIO_17__GPIO_7_12 | MUX_PAD_CTRL(NO_PAD_CTRL),
+};
+
 static void setup_iomux_enet(void)
 {
        gpio_direction_output(87, 0);  /* GPIO 3-23 */


Will be fixed in v2.

> 
> mx6qsabrelite.c: error: 'usb_pads' undeclared (first use in this function)
> 
>> +    /* Reset USB hub */
>> +    gpio_direction_output(204, 0); /* GPIO 7-12 */
> 
> With
> 
> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=7861b0f3eb638df23b992f89229c3b416634b6fa
> 
> 
> we might want to use something like
> 
> gpio_direction_output(GPIO_NUMBER(7, 12), 0);

OK, unfortunately, that file is full of such calls using the
number directly ==> seperate patch.

> ?
> 
> Same below for gpio_set_value() ?
> 
>> +    mdelay(2);
>> +    gpio_set_value(204, 1);
>> +}
> 
> mx6qsabrelite.c: warning: no return statement in function returning
> non-void

Puh, v1 is obviously crap... will send v2 in a second, sorry.

Wolfgang.