From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajay Bhargav Date: Mon, 13 Feb 2012 15:38:38 +0530 Subject: [U-Boot] [v2 2/4] USB: Armada100: ECHI Driver for Armada100 SOCs In-Reply-To: <201202131003.51680.marex@denx.de> References: <1329123447-21617-1-git-send-email-ajay.bhargav@einfochips.com> <1329123447-21617-2-git-send-email-ajay.bhargav@einfochips.com> <201202131003.51680.marex@denx.de> Message-ID: <4F38E126.3000809@einfochips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 13 February 2012 02:33 PM, Marek Vasut wrote: >> This patch adds support for USB EHCI driver for Armada100 SOCs. > Fix the subject, you have ECHI written there ;-) > what a blunder :) [...snip...] >> +#include >> +#include >> +#include >> +#include "ehci.h" >> +#include "ehci-core.h" >> +#include >> +#include >> +#include "utmi-armada100.h" > Where does this include come from? Maybe this should be part of the platform > includes in asm/arch/... and accessed as such too? > > M > Utmi might not be required outside usb.. so its always a part of USB. Do i really need to keep it out? Regards, Ajay Bhargav