From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Tricorder: Fix boot after making software ecc configurable
Date: Mon, 13 Feb 2012 17:05:34 -0600 [thread overview]
Message-ID: <4F39973E.1040108@freescale.com> (raw)
In-Reply-To: <CA+M6bXkKcL6b_C6y1do8E8ws4V1AHFr_Xwkn40SQLmSQEmFtWg@mail.gmail.com>
On 02/13/2012 04:14 PM, Tom Rini wrote:
> On Mon, Feb 13, 2012 at 2:44 PM, Scott Wood <scottwood@freescale.com> wrote:
>> On 02/13/2012 02:56 AM, Thomas Weber wrote:
>>> The tricorder stops booting with the following message:
>>>
>>> U-Boot 2011.12-00325-ga661206 (Feb 13 2012 - 09:29:50)
>>>
>>> OMAP3503-GP ES3.1, CPU-OPP2, L3-165MHz, Max CPU Clock 600 mHz
>>> OMAP3 Tricorder + LPDDR/NAND
>>> I2C: ready
>>> DRAM: 128 MiB
>>> NAND: CONFIG_MTD_ECC_SOFT not enabled
>>> 0 MiB
>>> MMC: OMAP SD/MMC: 0
>>>
>>> Adding CONFIG_MTD_ECC_SOFT to config file fixes this problem.
>>>
>>> Signed-off-by: Thomas Weber <weber@corscience.de>
>>> ---
>>> include/configs/tricorder.h | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> Sorry about that -- I meant to exclude "nand: make 1-bit software ECC
>> configurable" from the patchset I applied, due to the potential for this
>> sort of breakage.
>>
>> We should revert that patch until the issues raised here are resolved:
>> http://patchwork.ozlabs.org/patch/119149/
>
> I had / have plan to take the tricorder patch tomorrow, unless you
> really want to push a revert from your tree instead. Either way is
> fine with me.
This affects more than just tricorder -- any board that depends on soft
ECC will be broken, since none of them define this symbol. I thought I
had left this patch out, but apparently didn't.
-Scott
prev parent reply other threads:[~2012-02-13 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 8:56 [U-Boot] [PATCH] Tricorder: Fix boot after making software ecc configurable Thomas Weber
2012-02-13 21:44 ` Scott Wood
2012-02-13 22:14 ` Tom Rini
2012-02-13 23:05 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F39973E.1040108@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox